From: sashiko-bot@kernel.org
To: "Fil Dunsky" <filipp.dunsky@gmail.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 2/2] gpio: Add Cortina Systems CS75xx GPIO driver
Date: Thu, 19 Nov 2026 11:21:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-223020@kernel.org> (raw)
In-Reply-To: <20261119-cs75xx-gpio-v5-2-8d14f2bb614b@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] gpio: cs75xx: Kconfig depends on undefined symbol
ARCH_CORTINA_ACCESS
--
commit 7ff70214d7eee77eeaf70112de74f2b1043247c0
Author: Fil Dunsky <filipp.dunsky@gmail.com>
gpio: Add Cortina Systems CS75xx GPIO driver
This commit adds a GPIO and interrupt controller driver for the Cortina
Systems CS75xx SoCs using gpio-mmio.
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 55e4280029d86..cc00cfe48d941 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -300,6 +300,18 @@ config GPIO_CLPS711X
> help
> Say yes here to support GPIO on CLPS711X SoCs.
>
> +config GPIO_CS75XX
> + tristate "Cortina Systems CS75xx GPIO support"
> + depends on ARCH_CORTINA_ACCESS || COMPILE_TEST
[Severity: Low]
Is ARCH_CORTINA_ACCESS defined in Kconfig? Without a Kconfig definition
for it, GPIO_CS75XX can only be enabled when COMPILE_TEST is set, and
scripts/checkkconfigsymbols.py flags ARCH_CORTINA_ACCESS as an undefined
symbol.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-cs75xx-gpio-v5-0-8d14f2bb614b@gmail.com?part=2
prev parent reply other threads:[~2026-11-19 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:02 [PATCH v5 0/2] gpio: Add Cortina Systems CS75xx GPIO driver Fil Dunsky via B4 Relay
2026-11-19 11:02 ` [PATCH v5 1/2] dt-bindings: gpio: Add Cortina Systems CS7542 GPIO controller Fil Dunsky via B4 Relay
2026-11-19 11:02 ` [PATCH v5 2/2] gpio: Add Cortina Systems CS75xx GPIO driver Fil Dunsky via B4 Relay
2026-11-19 11:21 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223020@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=filipp.dunsky@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox