Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 08/11] PM / devfreq: rockchip-dfi: make RK3588 use its clocks
Date: Thu, 19 Nov 2026 13:13:54 +0000	[thread overview]
Message-ID: <sashiko-outbox-223156@kernel.org> (raw)
In-Reply-To: <20261119-rockchip-dfi-rk3588-cleanups-and-rk3576-support-v4-8-517a68c008fe@collabora.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PM / devfreq: rockchip-dfi: missing kernel-doc short description
--

commit 24f7e34d7d4ec9010ccc0577ac36a0764e1b939d
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

PM / devfreq: rockchip-dfi: make RK3588 use its clocks

This commit adds optional bulk clock support to struct rockchip_dfi_variant
and populates the per-channel DDRMON clocks for RK3588.

> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 2b9d9b26b11a4..c51d7eeec3946 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -117,6 +117,18 @@ struct rockchip_dfi {
>  	const struct rockchip_dfi_variant *variant;
>  };
>  
> +/**
> + * struct rockchip_dfi_variant
> + * @init: pointer to the variant-specific initialisation function

[Severity: Low]
Should this kernel-doc header line include a "- short description" after
"struct rockchip_dfi_variant"?  Without it, building with W=2 emits a
kernel-doc "missing initial short description on line" warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-rockchip-dfi-rk3588-cleanups-and-rk3576-support-v4-0-517a68c008fe@collabora.com?part=8

  reply	other threads:[~2026-11-19 13:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:01 [PATCH v4 00/11] PM / devfreq: rockchip-dfi: cleanups and RK3576 support Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 01/11] dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588 Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 02/11] dt-bindings: devfreq: event: rockchip,dfi: add rk3576 Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 03/11] PM / devfreq: rockchip-dfi: drop incorrect shift of LP5 bank mode Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 04/11] PM / devfreq: rockchip-dfi: initialize dmc_count structs Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 05/11] PM / devfreq: rockchip-dfi: move to per-variant const structs Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 06/11] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 07/11] PM / devfreq: rockchip-dfi: use bulk clock APIs Sebastian Reichel
2026-11-19 13:01 ` [PATCH v4 08/11] PM / devfreq: rockchip-dfi: make RK3588 use its clocks Sebastian Reichel
2026-11-19 13:13   ` sashiko-bot [this message]
2026-11-19 13:01 ` [PATCH v4 09/11] PM / devfreq: rockchip-dfi: move register offsets to variant struct Sebastian Reichel
2026-11-19 13:02 ` [PATCH v4 10/11] PM / devfreq: rockchip-dfi: prepare support for v4 DDRMON Sebastian Reichel
2026-11-19 13:02 ` [PATCH v4 11/11] PM / devfreq: rockchip-dfi: add RK3576 support Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223156@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox