Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Griffin Kroah-Hartman" <griffin.kroah@fairphone.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add AW8695 haptics
Date: Thu, 19 Nov 2026 14:05:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-223245@kernel.org> (raw)
In-Reply-To: <20261119-aw8695_haptic_fp4_driver-v4-3-9d107334bdb2@fairphone.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] Input: aw8695: broken work ordering and mode handling in
  aw8695_resume()
--

commit 0143deb4a0e86b5f6fa2fec12dfcfe91ccf02929
Author: Luca Weiss <luca.weiss@fairphone.com>

arm64: dts: qcom: sm7225-fairphone-fp4: Add AW8695 haptics

This commit adds the AW8695 haptics device node and its pinctrl states to
the Fairphone 4 devicetree.

> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 773304b4759e6..25237b8fcb9e5 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -707,7 +707,17 @@ vreg_l7p: ldo7 {
>  
>  	/* PX8618 @ 26 */
>  	/* SMB1395 PMIC @ 34 */
> -	/* awinic,aw8695 @ 5a */
> +
> +	haptics@5a {
> +		compatible = "awinic,aw8695";
> +		reg = <0x5a>;
> +
> +		interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
> +		reset-gpios = <&tlmm 90 GPIO_ACTIVE_LOW>;
> +
> +		pinctrl-0 = <&aw8695_int_default>, <&aw8695_reset_default>;
> +		pinctrl-names = "default";
> +	};

[Severity: Medium]
Can aw8695_resume() in the awinic,aw8695 driver (added in commit "Input -
aw8695: Add driver for AW8695 haptics") drop playback requests or leave a
stale non-zero haptics->level across system suspend and resume?

drivers/input/misc/aw8695.c:aw8695_resume() {
	if (!haptics->suspend)
		return 0;

	enable_work(&haptics->play_work);
	aw8695_haptic_set_active(haptics);
	aw8695_play_mode(haptics, AW8695_STANDBY_MODE);
	haptics->suspend = false;
	return 0;
}

aw8695_resume() calls enable_work(&haptics->play_work) before its sleeping
I2C transfers and before clearing haptics->suspend, so any play_work that
runs during that window hits if (haptics->suspend) return in
aw8695_haptics_play_work() and is dropped.

Because aw8695_haptics_play() does not check haptics->suspend, an ff-memless
timer event during suspend or before haptics->suspend is cleared updates
haptics->level while the work is rejected or dropped.  After resume finishes
with the motor in AW8695_STANDBY_MODE, haptics->level retains the stale
non-zero value and later aw8695_haptics_play() calls at the same magnitude
return early at if (haptics->level == level) without starting playback.

aw8695_resume() also wakes the chip via aw8695_haptic_set_active() only to
immediately put it back into AW8695_STANDBY_MODE (which aw8695_stop() in
aw8695_suspend() already entered), and neither aw8695_suspend() nor
aw8695_resume() checks the error return values of aw8695_stop(),
aw8695_haptic_set_active(), or aw8695_play_mode().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-aw8695_haptic_fp4_driver-v4-0-9d107334bdb2@fairphone.com?part=3

  reply	other threads:[~2026-11-19 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:54 [PATCH v4 0/4] AW8695 haptic driver Griffin Kroah-Hartman
2026-11-19 13:54 ` [PATCH v4 1/4] dt-bindings: input: Add compatibility for Awinic AW8695 Griffin Kroah-Hartman
2026-11-19 13:54 ` [PATCH v4 2/4] Input - aw8695: Add driver for AW8695 haptics Griffin Kroah-Hartman
2026-11-19 14:10   ` sashiko-bot
2026-11-19 13:54 ` [PATCH v4 3/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add " Griffin Kroah-Hartman
2026-11-19 14:05   ` sashiko-bot [this message]
2026-11-19 13:54 ` [PATCH v4 4/4] MAINTAINERS: add entry for AWINIC haptic driver family Griffin Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223245@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=griffin.kroah@fairphone.com \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox