Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Paul Cercueil" <paul.cercueil@bootlin.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mailbox: add Marvell MHU
Date: Thu, 19 Nov 2026 15:38:54 +0000	[thread overview]
Message-ID: <sashiko-outbox-223397@kernel.org> (raw)
In-Reply-To: <20261119152944.276763-2-paul.cercueil@bootlin.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: mailbox: marvell,mhu: broken .yml path and order in
  MAINTAINERS
- [Low] dt-bindings: mailbox: marvell,mhu: indentation and style issues
  in DTS example
--

commit 4caa249d5ea1d3d9950edc33feb82a1fda934ec0
Author: George Cherian <gcherian@marvell.com>

dt-bindings: mailbox: add Marvell MHU

This commit adds the device tree binding schema and MAINTAINERS entry for
the Marvell Message Handling Unit mailbox controller on OcteonTX and
OcteonTX2 SoCs.

> diff --git a/Documentation/devicetree/bindings/mailbox/marvell,mhu.yaml b/Documentation/devicetree/bindings/mailbox/marvell,mhu.yaml
> new file mode 100644
> index 0000000000000..228607165f850
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/marvell,mhu.yaml
> @@ -0,0 +1,60 @@

[ ... ]

> +examples:
> +  - |
> +    ecam {
> +        #address-cells = <3>;
> +        #size-cells = <2>;
> +            mailbox: mailbox@1c,0 {
> +                compatible = "marvell,octeontx2-mhu";
> +                reg = <0xe000 0x0 0x0 0 0>;
> +                #mbox-cells = <1>;
> +            };
> +    };

[Severity: Low]
In this DTS example, the child node mailbox@1c,0 is indented by 8 spaces
relative to ecam instead of 4 spaces, is missing a blank line after
#size-cells = <2>;, and defines an unused mailbox: label.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 65e8a4b5c90b1..b592a62a5c563 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15959,6 +15959,12 @@ R:	Vamsi Attunuru <vattunuru@marvell.com>
>  S:	Supported
>  F:	drivers/pci/hotplug/octep_hp.c
>  
> +MARVELL MHU MAILBOX DRIVER
> +M:	Sujeet Baranwal <sbaranwal@marvell.com>
> +M:	George Cherian <gcherian@marvell.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/mailbox/marvell,mhu.yml
> +
>  MATROX FRAMEBUFFER DRIVER
>  L:	linux-fbdev@vger.kernel.org
>  S:	Orphan

[Severity: Low]
Should this F: entry end in .yaml instead of .yml to match the file created
by this commit?  Because the path does not exist, scripts/get_maintainer.pl
will not match the binding file and --self-test=patterns reports a broken
file pattern.  Also, MARVELL MHU MAILBOX DRIVER is placed after MARVELL
OCTEON HOTPLUG DRIVER rather than in alphabetical order between MARVELL
MACCHIATOBIN SUPPORT and MARVELL MV643XX ETHERNET DRIVER.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119152944.276763-1-paul.cercueil@bootlin.com?part=1

  reply	other threads:[~2026-11-19 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:29 [PATCH 0/3] mailbox: Add Marvell MHU driver Paul Cercueil
2026-11-19 15:29 ` [PATCH 1/3] dt-bindings: mailbox: add Marvell MHU Paul Cercueil
2026-11-19 15:38   ` sashiko-bot [this message]
2026-11-19 15:29 ` [PATCH 2/3] mailbox: marvell-mhu: add Marvell MHU driver Paul Cercueil
2026-11-19 15:29 ` [PATCH 3/3] scmi: driver: Increase timeout for rx response Paul Cercueil
2026-11-19 15:38   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223397@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=paul.cercueil@bootlin.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox