From: sashiko-bot@kernel.org
To: "Icenowy Zheng" <zhengxingda@iscas.ac.cn>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: document TH1520 MIPI DSI controller
Date: Thu, 19 Nov 2026 15:56:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-223445@kernel.org> (raw)
In-Reply-To: <20261119-th1520-dw-mipi-dsi-v2-1-9ab5f9808f87@iscas.ac.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: display: thead,th1520-dw-mipi-dsi example uses
syscon property
--
commit d819a2c2851c2350a4e59d7f97fa2750cf5e7ffc
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
dt-bindings: display: bridge: document TH1520 MIPI DSI controller
This commit adds a Device Tree binding schema for the Synopsys DesignWare
MIPI DSI host controller on the T-Head TH1520 SoC.
> diff --git a/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml
> new file mode 100644
> index 0000000000000..4d6452a027348
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml
> @@ -0,0 +1,102 @@
[ ... ]
> + thead,vo-syscon:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to the VO_SUBSYS system controller.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - interrupts
> + - thead,vo-syscon
> + - ports
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/reset/thead,th1520-reset.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + dsi0: dsi@ffef500000 {
> + compatible = "thead,th1520-dw-mipi-dsi";
> + reg = <0xff 0xef500000 0x0 0x1000>;
> + interrupts = <119 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk_vo CLK_MIPI_DSI0_PCLK>,
> + <&clk_vo CLK_MIPI_DSI0_CFG>,
> + <&clk_vo CLK_MIPI_DSI0_REFCLK>,
> + <&clk_vo CLK_MIPIDSI0_PIXCLK>;
> + clock-names = "pclk", "phy_cfg", "ref", "pixel";
> + resets = <&rst TH1520_RESET_ID_DSI0_APB>;
> + reset-names = "apb";
> + syscon = <&syscon_vo>;
[Severity: Medium]
As reported by Krzysztof Kozlowski on v1 [1], should the example use
thead,vo-syscon instead of syscon? Because thead,vo-syscon is required
and unevaluatedProperties is false, dt_binding_check fails on the example.
In addition, the thead,vo-syscon description still does not explain what
the DSI controller uses the VO_SUBSYS system controller for.
[1] https://lore.kernel.org/r/20261102-spry-snobbish-hound-384cae@quoll
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-th1520-dw-mipi-dsi-v2-0-9ab5f9808f87@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-19 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 15:50 [PATCH v2 0/2] drm/bridge: add glue driver for T-Head TH1520 DW MIPI DSI Icenowy Zheng
2026-11-19 15:50 ` [PATCH v2 1/2] dt-bindings: display: bridge: document TH1520 MIPI DSI controller Icenowy Zheng
2026-11-19 15:56 ` sashiko-bot [this message]
2026-11-19 15:50 ` [PATCH v2 2/2] drm/bridge: add TH1520 DesignWare MIPI DSI host controller Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223445@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox