Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arthur Heymans" <arthur@aheymans.xyz>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH wireless-next 07/10] dt-bindings: net: wireless: add XRadio XR819
Date: Thu, 19 Nov 2026 18:03:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-223749@kernel.org> (raw)
In-Reply-To: <20261119175002.458988-8-arthur@aheymans.xyz>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: wireless: xradio,xr819: missing
  wireless-controller.yaml ref
--

commit b88f95dc24f2d5de0e0e72e80a5e05cb457e6ac2
Author: Arthur Heymans <arthur@aheymans.xyz>

dt-bindings: net: wireless: add XRadio XR819

This commit adds a DT binding schema for the XRadio XR819 SDIO wireless
controller and adds it to MAINTAINERS under the CW1200 WLAN driver entry.

> diff --git a/Documentation/devicetree/bindings/net/wireless/xradio,xr819.yaml b/Documentation/devicetree/bindings/net/wireless/xradio,xr819.yaml
> new file mode 100644
> index 0000000000000..4f6919b6bcbd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/xradio,xr819.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/xradio,xr819.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: XRadio XR819 SDIO wireless controller
> +
> +maintainers:
> +  - Arthur Heymans <arthur@aheymans.xyz>
> +
> +description:
> +  The XR819 is a 2.4 GHz IEEE 802.11b/g/n controller connected to the host
> +  through SDIO. Its out-of-band interrupt may be connected to a host GPIO.
> +
> +properties:
> +  compatible:
> +    const: xradio,xr819
> +
> +  reg:
> +    const: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  local-mac-address: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Low]
Should this schema reference wireless-controller.yaml# with
unevaluatedProperties: false instead of listing local-mac-address: true with
additionalProperties: false?

Neither wireless-controller.yaml nor network-class.yaml sets select: true, so
listing local-mac-address: true leaves it without its uint8-array type and
6-byte length constraints from network-class.yaml, while additionalProperties:
false rejects other standard properties from wireless-controller.yaml such as
mac-address (which of_get_mac_address() in cw1200_sdio_probe() checks first
and which bootloaders populate via ethernet aliases).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119175002.458988-1-arthur@aheymans.xyz?part=7

  parent reply	other threads:[~2026-11-19 18:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:49 [PATCH wireless-next 00/10] wifi: cw1200: add XRadio XR819 support Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 01/10] wifi: cw1200: avoid removing the debugfs directory twice Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 02/10] wifi: cw1200: check SDD element lengths before reading them Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 03/10] wifi: cw1200: bounce SDIO transfers that use stack buffers Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 04/10] wifi: cw1200: unwind GPIO interrupt setup on error Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 05/10] wifi: cw1200: unregister from mac80211 before freeing the interrupt Arthur Heymans
2026-11-19 17:49 ` [PATCH wireless-next 06/10] dt-bindings: vendor-prefixes: add XRadio Arthur Heymans
2026-11-19 18:03   ` Conor Dooley
2026-11-19 17:49 ` [PATCH wireless-next 07/10] dt-bindings: net: wireless: add XRadio XR819 Arthur Heymans
2026-11-19 18:01   ` Conor Dooley
2026-11-19 18:03   ` sashiko-bot [this message]
2026-11-19 17:50 ` [PATCH wireless-next 08/10] wifi: cw1200: load the XR819 bootloader into SRAM Arthur Heymans
2026-11-19 17:50 ` [PATCH wireless-next 09/10] wifi: cw1200: add XR819 SDIO support Arthur Heymans
2026-11-19 17:50 ` [PATCH wireless-next 10/10] MAINTAINERS: add myself for the cw1200 driver Arthur Heymans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223749@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=arthur@aheymans.xyz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox