Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jernej Skrabec" <jernej.skrabec@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-sunxi@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH v4 1/5] drm/sun4i: Reject fractional source coordinates without scaler
Date: Thu, 19 Nov 2026 18:03:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-223750@kernel.org> (raw)
In-Reply-To: <20261119175437.2520400-2-jernej.skrabec@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sun4i: missing Fixes trailer for fractional source
  coordinate check
--

commit 6372f45de588428ede3ebc1410bcfe779db4f206
Author: Jernej Skrabec <jernej.skrabec@gmail.com>

> drm/sun4i: Reject fractional source coordinates without scaler
>
> The layer code programs the scaler whenever the source rectangle has a
> fractional offset, since only the scaler can apply a sub-pixel phase.
> drm_atomic_helper_check_plane_state() with DRM_PLANE_NO_SCALING doesn't
> catch that: it only compares the scaling factor, which may still be
> exactly 1.0 with fractional source coordinates.
>
> Channels without a scaler would thus have the non-existent scaler
> programmed instead of an error being returned. Reject fractional source
> coordinates on such channels.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

[Severity: Low]
This fixes the scaling check introduced when hardware scaling support was
added to DE2.  Should this include:

  Fixes: b862a648de3b ("drm/sun4i: Add support for HW scaling to DE2")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119175437.2520400-1-jernej.skrabec@gmail.com?part=1

  reply	other threads:[~2026-11-19 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:54 [PATCH v4 0/5] drm/sun4i: update DE33 support Jernej Skrabec
2026-11-19 17:54 ` [PATCH v4 1/5] drm/sun4i: Reject fractional source coordinates without scaler Jernej Skrabec
2026-11-19 18:03   ` sashiko-bot [this message]
2026-11-19 17:54 ` [PATCH v4 2/5] dt-bindings: display: allwinner: Add DE33 planes Jernej Skrabec
2026-11-19 17:54 ` [PATCH v4 3/5] drm/sun4i: Add DE33 shared plane driver Jernej Skrabec
2026-11-19 17:54 ` [PATCH v4 4/5] dt-bindings: display: allwinner: Split H616 DE33 layer reg space Jernej Skrabec
2026-11-19 17:54 ` [PATCH v4 5/5] drm/sun4i: Switch DE33 to split plane bindings Jernej Skrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223750@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox