From: sashiko-bot@kernel.org
To: "Dawid Glazik" <dawid.glazik@linux.intel.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 2/3] ARM: dts: aspeed: Add Intel AVCRP BMC
Date: Thu, 19 Nov 2026 18:33:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-223774@kernel.org> (raw)
In-Reply-To: <e37637a0be15a3567f0d805d6bdc7b375ebd3a1a.1795114204.git.dawid.glazik@linux.intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: aspeed: avcrp: unnecessary RMII RCLK clock specified
on RGMII mac1
--
commit 73259580cccaecd0b0979753a09f8fcb15e20987
Author: Dawid Glazik <dawid.glazik@linux.intel.com>
ARM: dts: aspeed: Add Intel AVCRP BMC
This commit adds the device tree for the AST2600-based RunBMC module on
the Intel AVCRP server platform.
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts
> new file mode 100644
> index 0000000000000..02cdeca78048a
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts
> @@ -0,0 +1,326 @@
[ ... ]
> +&mac1 {
> + clocks = <&syscon ASPEED_CLK_GATE_MAC2CLK>,
> + <&syscon ASPEED_CLK_MAC2RCLK>;
> + clock-names = "MACCLK", "RCLK";
> + phy-handle = <ðphy1>;
> + phy-mode = "rgmii-id";
> + pinctrl-0 = <&pinctrl_rgmii2_default>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
[Severity: Low]
Does mac1 need clocks and clock-names overridden here?
ASPEED_CLK_MAC2RCLK (RCLK) is the RMII 50 MHz reference clock gate,
whereas mac1 is configured for RGMII (phy-mode = "rgmii-id") and
aspeed-g6.dtsi already provides ASPEED_CLK_GATE_MAC2CLK. Specifying RCLK
causes ftgmac100_setup_clk() to unnecessarily enable the RMII2 RCLK gate.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795114204.git.dawid.glazik@linux.intel.com?part=2
next prev parent reply other threads:[~2026-11-19 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 19:19 [PATCH v6 0/3] ARM: dts: aspeed: Add Intel AVCRP and JNCRP BMC platforms Dawid Glazik
2026-11-19 19:19 ` [PATCH v6 1/3] dt-bindings: arm: aspeed: Add Intel AVCRP and JNCRP boards Dawid Glazik
2026-11-19 19:19 ` [PATCH v6 2/3] ARM: dts: aspeed: Add Intel AVCRP BMC Dawid Glazik
2026-11-19 18:33 ` sashiko-bot [this message]
2026-11-19 19:19 ` [PATCH v6 3/3] ARM: dts: aspeed: Add Intel JNCRP BMC Dawid Glazik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223774@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dawid.glazik@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox