From: sashiko-bot@kernel.org
To: "Gopikishan Thawre" <gopikishan.thawre@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: lemans: Add LeMans Draco EVK SoM platform
Date: Fri, 20 Nov 2026 07:11:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-224599@kernel.org> (raw)
In-Reply-To: <20261119-lemans-draco-final-changes-bringup-v3-2-db08f12f0cd5@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: lemans-draco-som: swapped USB QMP PHY vdda
supplies
--
commit 53f3c4c5688995a724474882d7b554c0d74f4ff6
Author: Gopikishan Thawre <gopikishan.thawre@oss.qualcomm.com>
arm64: dts: qcom: lemans: Add LeMans Draco EVK SoM platform
This commit adds the initial device tree for the SA8775P/QCS9100-based
LeMans Draco EVK SoM platform.
> diff --git a/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi b/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi
> new file mode 100644
> index 0000000000000..1001b6b81c312
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-draco-som.dtsi
> @@ -0,0 +1,421 @@
[ ... ]
> +&usb_0_qmpphy {
> + vdda-phy-supply = <&vreg_l1c>;
> + vdda-pll-supply = <&vreg_l7a>;
> +
> + status = "okay";
> +};
> +
> +&usb_1 {
> + dr_mode = "host";
> +
> + status = "okay";
> +};
> +
> +&usb_1_hsphy {
> + vdda-pll-supply = <&vreg_l7a>;
> + vdda18-supply = <&vreg_l6c>;
> + vdda33-supply = <&vreg_l9a>;
> +
> + status = "okay";
> +};
> +
> +&usb_1_qmpphy {
> + vdda-phy-supply = <&vreg_l1c>;
> + vdda-pll-supply = <&vreg_l7a>;
> +
> + status = "okay";
> +};
[Severity: Medium]
Are vdda-phy-supply and vdda-pll-supply swapped on usb_0_qmpphy and
usb_1_qmpphy?
vreg_l1c is the ~1.2V rail and vreg_l7a is the ~0.88V rail, whereas the
QMP PHY expects the lower voltage on vdda-phy-supply and the 1.2V rail
on vdda-pll-supply (matching ufs_mem_phy above and commit 932113c3c778
("arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll
supplies")). Because both regulators set regulator-allow-set-load, the
QMP USB PHY driver also programs its vdda-phy and vdda-pll load votes
onto the wrong LDOs.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-lemans-draco-final-changes-bringup-v3-0-db08f12f0cd5@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-20 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:10 [PATCH v3 0/3] arm64: dts: qcom: lemans: Add LeMans Draco EVK board support Gopikishan Thawre
2026-11-19 7:10 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add LeMans Draco EVK board Gopikishan Thawre
2026-11-19 7:10 ` [PATCH v3 2/3] arm64: dts: qcom: lemans: Add LeMans Draco EVK SoM platform Gopikishan Thawre
2026-11-20 7:11 ` sashiko-bot [this message]
2026-11-19 7:10 ` [PATCH v3 3/3] arm64: dts: qcom: lemans: Add LeMans Draco EVK board Gopikishan Thawre
2026-11-20 7:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224599@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gopikishan.thawre@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox