Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: ipq9650: Add RDP488 NAND variant
Date: Fri, 20 Nov 2026 09:07:51 +0000	[thread overview]
Message-ID: <sashiko-outbox-224824@kernel.org> (raw)
In-Reply-To: <20261120-ipq9650_various_devices-v1-4-14f53b84c42c@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: ipq9650-rdp488-nand leaves unused sdhc_ice
  enabled
--

commit ad5347a3cef492083ed05d894cccf1bc85330536
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq9650: Add RDP488 NAND variant

This commit adds the device tree for the IPQ9650 RDP488 NAND variant,
enables the QPIC NAND controller, and adds the target to the Makefile.

> diff --git a/arch/arm64/boot/dts/qcom/ipq9650-rdp488-nand.dts b/arch/arm64/boot/dts/qcom/ipq9650-rdp488-nand.dts
> new file mode 100644
> index 0000000000000..fe592e04551c0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq9650-rdp488-nand.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +
> +#include "ipq9650-rdp488-common.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. IPQ9650 RDP488 (NAND)";
> +	compatible = "qcom,ipq9650-rdp488", "qcom,ipq9650";
> +};
> +
> +&qpic_nand {
> +	status = "okay";
> +};

[Severity: Low]
Does including ipq9650-rdp488-common.dtsi leave sdhc_ice enabled on this
NAND variant?

ipq9650-rdp488-common.dtsi sets status = "okay" on &sdhc_ice (in addition
to ipq9650-rdp488.dts enabling both &sdhc and &sdhc_ice).  Because the
NAND variant leaves &sdhc disabled, sdhc_ice still probes and keeps its
clocks enabled for an unused eMMC inline crypto engine.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-ipq9650_various_devices-v1-0-14f53b84c42c@oss.qualcomm.com?part=4

      reply	other threads:[~2026-11-20  9:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  8:59 [PATCH 0/4] arm64: dts: qcom: ipq9650: add and enable various devices Kathiravan Thirumoorthy
2026-11-20  8:59 ` [PATCH 1/4] arm64: dts: qcom: ipq9650: fix the TCSR mutex address range Kathiravan Thirumoorthy
2026-11-20  8:59 ` [PATCH 2/4] arm64: dts: qcom: ipq9650: add RDP488 common DT file Kathiravan Thirumoorthy
2026-11-20  8:59 ` [PATCH 3/4] arm64: dts: qcom: ipq9650: add and enable various device nodes Kathiravan Thirumoorthy
2026-11-20  9:32   ` sashiko-bot
2026-11-20  8:59 ` [PATCH 4/4] arm64: dts: qcom: ipq9650: Add RDP488 NAND variant Kathiravan Thirumoorthy
2026-11-20  9:07   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224824@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox