Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vyacheslav Yurkov" <V.Yurkov.EXT@bruker.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: bus: Add Altera AXI Timeout Bridge
Date: Fri, 20 Nov 2026 09:32:12 +0000	[thread overview]
Message-ID: <sashiko-outbox-224852@kernel.org> (raw)
In-Reply-To: <20261120-feature-timeout-ip-v3-1-affcc644af5e@bruker.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: bus: non-canonical property order in
  axi-timeout-bridge example
--

commit f9313b89c46a716fd7317e81e51cf84dd43ee870
Author: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>

dt-bindings: bus: Add Altera AXI Timeout Bridge

This commit adds a devicetree binding schema for the Altera AXI Timeout
Bridge FPGA IP core.

> diff --git a/Documentation/devicetree/bindings/bus/altr,axi-timeout-bridge-1.0.yaml b/Documentation/devicetree/bindings/bus/altr,axi-timeout-bridge-1.0.yaml
> new file mode 100644
> index 0000000000000..2cf1ab537595b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/altr,axi-timeout-bridge-1.0.yaml
> @@ -0,0 +1,86 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    bus@10000 {
> +        compatible = "altr,axi-timeout-bridge-1.0";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        reg = <0x10000 0x10>;
> +        interrupts = <0 12 IRQ_TYPE_LEVEL_HIGH>;
> +        ranges = <0x0 0x10010 0x1000>;

[Severity: Low]
In the bus@10000 example node, reg and ranges should come immediately
after compatible, before #address-cells, #size-cells and interrupts, to
match the DTS coding style and pass scripts/dtc/dt-check-style in strict
mode without property-order warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-feature-timeout-ip-v3-0-affcc644af5e@bruker.com?part=1

  reply	other threads:[~2026-11-20  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  9:24 [PATCH v3 0/2] Add Altera timeout bridge driver Vyacheslav Yurkov via B4 Relay
2026-11-20  9:24 ` [PATCH v3 1/2] dt-bindings: bus: Add Altera AXI Timeout Bridge Vyacheslav Yurkov via B4 Relay
2026-11-20  9:32   ` sashiko-bot [this message]
2026-11-20  9:24 ` [PATCH v3 2/2] bus: Add Altera AXI Timeout Bridge driver Vyacheslav Yurkov via B4 Relay
2026-11-20  9:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224852@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=V.Yurkov.EXT@bruker.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox