From: sashiko-bot@kernel.org
To: "Jacky Chou" <jacky_chou@aspeedtech.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v7 5/7] net: ftgmac100: Require phy-mode for AST2700
Date: Fri, 20 Nov 2026 09:33:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-224858@kernel.org> (raw)
In-Reply-To: <20261119-support_ast2700-v7-5-33c8ca2d0dd7@aspeedtech.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net: ftgmac100: unreachable AST2700 phy-mode check in
ftgmac100_mii_probe()
--
commit b86b29199842bf4516e7a704118276e8a5eb8767
Author: Jacky Chou <jacky_chou@aspeedtech.com>
net: ftgmac100: Require phy-mode for AST2700
This commit requires the device tree "phy-mode" property to be specified
on AST2700 in ftgmac100_mii_probe(), returning -EINVAL instead of
defaulting to RGMII.
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 9b7becb017262..5a578a62df673 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1526,8 +1526,13 @@ static int ftgmac100_mii_probe(struct net_device *netdev)
>
> /* Default to RGMII. It's a gigabit part after all */
> err = of_get_phy_mode(np, &phy_intf);
> - if (err)
> + if (err) {
> + if (priv->mac_id == FTGMAC100_AST2700) {
> + dev_err(priv->dev, "phy-mode is required for this SoC\n");
> + return -EINVAL;
> + }
> phy_intf = PHY_INTERFACE_MODE_RGMII;
> + }
[Severity: Medium]
Can this FTGMAC100_AST2700 check ever be reached?
ftgmac100_mii_probe() returns -ENODEV right above this when !priv->mii_bus,
and priv->mii_bus is only allocated by ftgmac100_setup_mdio(), which
ftgmac100_probe() only calls for FTGMAC100_FARADAY, FTGMAC100_AST2400, and
FTGMAC100_AST2500:
drivers/net/ethernet/faraday/ftgmac100.c:ftgmac100_probe() {
...
if (priv->mac_id == FTGMAC100_FARADAY ||
priv->mac_id == FTGMAC100_AST2400 ||
priv->mac_id == FTGMAC100_AST2500) {
err = ftgmac100_setup_mdio(netdev);
if (err)
return err;
}
...
}
For FTGMAC100_AST2700, priv->mii_bus is always NULL, so
ftgmac100_mii_probe() always exits with "No MDIO bus available" before
reaching of_get_phy_mode().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-support_ast2700-v7-0-33c8ca2d0dd7@aspeedtech.com?part=5
next prev parent reply other threads:[~2026-11-20 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:32 [PATCH net-next v7 0/7] net: ftgmac100: Add AST2700 support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 1/7] dt-bindings: net: ftgmac100: Make Aspeed compatibles standalone Jacky Chou
2026-11-20 9:32 ` sashiko-bot
2026-11-19 9:32 ` [PATCH net-next v7 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 3/7] net: ftgmac100: Add AST2700 compatible support Jacky Chou
2026-11-20 9:32 ` sashiko-bot
2026-11-19 9:32 ` [PATCH net-next v7 4/7] net: ftgmac100: Enable AST2700 RMII support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 5/7] net: ftgmac100: Require phy-mode for AST2700 Jacky Chou
2026-11-20 9:33 ` sashiko-bot [this message]
2026-11-19 9:32 ` [PATCH net-next v7 6/7] net: ftgmac100: Add AST2700 upper DMA address support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 7/7] net: ftgmac100: Allow building on ARM64 Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224858@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacky_chou@aspeedtech.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox