Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Matti Vaittinen" <matti.vaittinen@linux.dev>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111
Date: Fri, 20 Nov 2026 12:34:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-225147@kernel.org> (raw)
In-Reply-To: <4be17e339f768da93db2f42abd3cc5a21fea01ad.1795176984.git.mazziesaccount@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] iio: adc: rohm-bd79112: double semicolon in bd79112_probe()
- [Low] iio: adc: rohm-bd79112: unused BD79112_MAX_NUM_CHANNELS macro
--

commit d2b6757018d5ccee4c939ad0350d93a29d26239d
Author: Matti Vaittinen <mazziesaccount@gmail.com>

iio: adc: rohm-bd79112: Support ROHM BD79111

This commit adds support for the 16-channel ROHM BD79111 SAR ADC and GPIO
device to the rohm-bd79112 driver.

> diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c
> index 04084e88984a5..8bbb86098ff5a 100644
> --- a/drivers/iio/adc/rohm-bd79112.c
> +++ b/drivers/iio/adc/rohm-bd79112.c

[ ... ]

> @@ -431,8 +458,17 @@ static const char * const bd79112_chan_names[] = {
>  	"AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B",	/* 28 - 31 */
>  };
>  
> +static const struct bd7911x_chip_data bd79111_chip_data = {
> +	.name = "bd79111",
> +	.chan_names = bd79111_chan_names,
> +	.num_max_channels = 16,
> +	.init_disable_gpios = bd79111_disable_gpios,
> +};
> +
>  static const struct bd7911x_chip_data bd79112_chip_data = {
> +	.name = "bd79112",
>  	.chan_names = bd79112_chan_names,
> +	.num_max_channels = 32,
>  	.init_disable_gpios = bd79112_disable_gpios,
>  };

[Severity: Low]
This isn't a bug, but replacing the remaining uses of
BD79112_MAX_NUM_CHANNELS in bd79112_probe() with
data->cd->num_max_channels leaves the BD79112_MAX_NUM_CHANNELS macro
unused.

[ ... ]

> @@ -509,7 +545,7 @@ static int bd79112_probe(struct spi_device *spi)
>  		cs[i].datasheet_name = data->cd->chan_names[cs[i].channel];
>  
>  	iio_dev->info = &bd79112_info;
> -	iio_dev->name = "bd79112";
> +	iio_dev->name = data->cd->name;;
>  	iio_dev->modes = INDIO_DIRECT_MODE;

[Severity: Low]
This isn't a bug, but there is a double semicolon at the end of this
assignment.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795176984.git.mazziesaccount@gmail.com?part=3

      reply	other threads:[~2026-11-20 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:26 [PATCH v2 0/3] Support ROHM BD79111 ADC/GPIO Matti Vaittinen
2026-11-20 12:27 ` [PATCH v2 1/3] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:34   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225147@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=matti.vaittinen@linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox