Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jonas Karlman" <jonas@kwiboo.se>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 8/8] ARM: dts: rockchip: Add Luckfox Lyra Zero W board
Date: Fri, 20 Nov 2026 15:21:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-225456@kernel.org> (raw)
In-Reply-To: <20261119152055.556266-9-jonas@kwiboo.se>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ARM: dts: rockchip: missing pinctrl properties on enabled
  fspi node
--

commit 48e50ced88fba2da121063679ad813c27667c9d5
Author: Jonas Karlman <jonas@kwiboo.se>

ARM: dts: rockchip: Add Luckfox Lyra Zero W board

This commit adds the device tree for the Rockchip RK3506B-based Luckfox
Lyra Zero W development board.

Link: https://wiki.luckfox.com/Luckfox-Lyra/Luckfox-Lyra-Zero-W

> diff --git a/arch/arm/boot/dts/rockchip/rk3506b-luckfox-lyra-zero-w.dts b/arch/arm/boot/dts/rockchip/rk3506b-luckfox-lyra-zero-w.dts
> new file mode 100644
> index 0000000000000..f2fa513e8bff1
> --- /dev/null
> +++ b/arch/arm/boot/dts/rockchip/rk3506b-luckfox-lyra-zero-w.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +#include "rk3506b-luckfox-lyra.dtsi"
> +
> +/ {
> +	model = "Luckfox Lyra Zero W";
> +	compatible = "luckfox,lyra-zero-w", "rockchip,rk3506";
> +};
> +
> +&fspi {
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "spi-nand";
> +		reg = <0>;
> +		bootph-pre-ram;
> +		bootph-some-ram;
> +		spi-max-frequency = <80000000>;
> +		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <1>;
> +	};
> +};

[Severity: Medium]
Should &fspi define pinctrl-names = "default" and pinctrl-0 = <&fspi_bus4
&fspi_clk &fspi_csn>?

The fspi node in rk3506.dtsi has no default pinctrl properties, and the
fspi_bus4, fspi_clk, and fspi_csn pinmux nodes in rk3506-pinctrl.dtsi are
marked /omit-if-no-ref/.  Without referencing them here, dtc strips those
pinmux nodes from the DTB and the pinctrl subsystem cannot mux the FSPI
pins when the bootloader has not pre-configured all four data lines.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119152055.556266-1-jonas@kwiboo.se?part=8

  reply	other threads:[~2026-11-20 15:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:20 [PATCH 0/8] ARM: dts: rockchip: Add Luckfox Lyra boards Jonas Karlman
2026-11-19 15:20 ` [PATCH 1/8] dt-bindings: soc: rockchip: grf: Add RK3506 compatibles Jonas Karlman
2026-11-19 15:20 ` [PATCH 2/8] ARM: dts: rockchip: Add support for RK3506 Jonas Karlman
2026-11-20 15:21   ` sashiko-bot
2026-11-19 15:20 ` [PATCH 3/8] dt-bindings: arm: rockchip: Add Luckfox Lyra and Lyra Plus Jonas Karlman
2026-11-19 15:20 ` [PATCH 4/8] ARM: dts: rockchip: Add Luckfox Lyra and Lyra Plus boards Jonas Karlman
2026-11-20 15:21   ` sashiko-bot
2026-11-19 15:20 ` [PATCH 5/8] dt-bindings: arm: rockchip: Add Luckfox Lyra Ultra Jonas Karlman
2026-11-19 15:20 ` [PATCH 6/8] ARM: dts: rockchip: Add Luckfox Lyra Ultra board Jonas Karlman
2026-11-19 15:20 ` [PATCH 7/8] dt-bindings: arm: rockchip: Add Luckfox Lyra Zero W Jonas Karlman
2026-11-19 15:20 ` [PATCH 8/8] ARM: dts: rockchip: Add Luckfox Lyra Zero W board Jonas Karlman
2026-11-20 15:21   ` sashiko-bot [this message]
2026-11-20  2:53 ` [PATCH 0/8] ARM: dts: rockchip: Add Luckfox Lyra boards Chaoyi Chen
2026-11-20  3:02   ` Chaoyi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225456@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox