From: sashiko-bot@kernel.org
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Mark Brown" <broonie@kernel.org>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Takahiro Kuwano" <takahiro.kuwano@infineon.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
praneeth@ti.com, u-kumar1@ti.com, p-mantena@ti.com,
a-dutta@ti.com, s-k6@ti.com, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 10/11] mtd: spi-nand: Set the DQS spi-mem capability if available
Date: Fri, 20 Nov 2026 17:30:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-225665@kernel.org> (raw)
In-Reply-To: <20261120-winbond-nand-next-phy-tuning-v4-10-8c21e1f71f41@bootlin.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mtd: spinand: spi_mem_set_dqs_pin_available() called after
SSDR negotiation
--
commit ded1f01b00a338383ed4e62228f6b415856c9df3
Author: Miquel Raynal <miquel.raynal@bootlin.com>
mtd: spi-nand: Set the DQS spi-mem capability if available
This commit adds the SPINAND_HAS_DQS flag and calls
spi_mem_set_dqs_pin_available() in spinand_match_and_init() when a
matched SPI-NAND chip supports DQS.
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index fee4a48b4c7f3..6e1b7976d2379 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1797,6 +1797,9 @@ int spinand_match_and_init(struct spinand_device *spinand,
> }
> }
>
> + if (spinand->flags & SPINAND_HAS_DQS)
> + spi_mem_set_dqs_pin_available(spinand->spimem);
> +
> /* I/O variants selection with octo-spi DDR commands (optional) */
>
> ret = spinand_init_odtr_instruction_set(spinand);
[Severity: Medium]
Should spi_mem_set_dqs_pin_available() be called right after
spinand->flags is initialized, before SSDR operation variants are
selected?
Placing it here leaves spinand->spimem->dqs_pin false while
spinand_select_op_variant(spinand, SSDR, ...) and
spinand_support_vendor_ops(spinand, info, SSDR) run, which also evaluate
1S-command DTR read variants such as
SPINAND_PAGE_READ_FROM_CACHE_1S_1D_8D_OP.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-winbond-nand-next-phy-tuning-v4-0-8c21e1f71f41@bootlin.com?part=10
next prev parent reply other threads:[~2026-11-20 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:14 [PATCH v4 00/11] mtd/spi-mem: Enable DQS control Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 01/11] spi: spi-mem: Rename the DQS setter and pin field Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 02/11] spi: spi-mem: Clarify the conditions upon which DQS is usable Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 03/11] dt-bindings: spi: Document the spi-dqs-not-wired property Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 04/11] spi: spi-mem: Take the DQS wiring into account Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 05/11] spi: spi-mem: Take the controller DQS support " Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 06/11] spi: cadence-quadspi: Advertise DQS support Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 07/11] spi: cadence-quadspi: Decouple the read capture bypass from DQS Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 08/11] spi: cadence-quadspi: Check DQS usability before enabling DQS capture Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 09/11] mtd: spi-nor: Advertise DQS support for octal DTR flashes Miquel Raynal
2026-11-20 17:14 ` [PATCH v4 10/11] mtd: spi-nand: Set the DQS spi-mem capability if available Miquel Raynal
2026-11-20 17:30 ` sashiko-bot [this message]
2026-11-20 17:14 ` [PATCH v4 11/11] mtd: spi-nand: winbond: Enable the DQS pin on W35N**JW series Miquel Raynal
2026-11-20 17:51 ` [PATCH v4 00/11] mtd/spi-mem: Enable DQS control Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225665@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=a-dutta@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=s-k6@ti.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=takahiro.kuwano@infineon.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox