Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kyle Hendry" <khendry@reliablecontrols.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org,
	wsa+renesas@sang-engineering.com
Subject: Re: [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure
Date: Fri, 20 Nov 2026 17:58:39 +0000	[thread overview]
Message-ID: <sashiko-outbox-225762@kernel.org> (raw)
In-Reply-To: <20261119-rzn1-miic-resets-v1-5-feee2bb28bb4@reliablecontrols.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] net: pcs: rzn1-miic: mandatory resets in
  miic_reset_control_init() fail probe
- [High] net: pcs: rzn1-miic: 1-based reset IDs fail
  miic_reset_control_init() lookup
--

commit cf9182d3fcd65a07b7b29000ceaaa7372b1589dd
Author: Kyle Hendry <khendry@reliablecontrols.com>

net: pcs: rzn1-miic: Add resets to rzn1 info structure

This commit adds the "rst_ts" and "rst_miic" reset names and count to
rzn1_miic_of_data so that the driver requests and deasserts the RZ/N1
MII converter resets.

> diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
> index f8bafce26bf13..38164502c08cf 100644
> --- a/drivers/net/pcs/pcs-rzn1-miic.c
> +++ b/drivers/net/pcs/pcs-rzn1-miic.c
> @@ -128,6 +128,11 @@ static const char * const index_to_string[] = {
>  	"CONV5",
>  };
>  
> +static const char * const rzn1_reset_ids[] = {
> +	"rst_ts",
> +	"rst_miic",
> +};
> +
>  static struct modctrl_match rzt2h_modctrl_match_table[] = {
>  	{0x0, {ETHSS_GMAC0_PORT, ETHSS_ETHSW_PORT0, ETHSS_ETHSW_PORT1,
>  	       ETHSS_ETHSW_PORT2, ETHSS_GMAC1_PORT}},

[Severity: High]
Does looking up rzn1_reset_ids[] fail in fwnode_reset_simple_xlate() when
the eth_miic node uses R9A06G032_RST_TS (1) and R9A06G032_RST_MIIC (2)?

include/dt-bindings/clock/r9a06g032-sysctrl.h defines R9A06G032_RST_TS as
1 and R9A06G032_RST_MIIC as 2, while r9a06g032_clocks_probe() registers a
2-entry r9a06g032_resets[] table (indices 0 and 1) with the default
0-based fwnode_reset_simple_xlate().  As a result, "rst_ts" (ID 1) maps
to r9a06g032_resets[1] (the MIIC reset bit instead of the timestamp reset
bit at index 0), and "rst_miic" (ID 2) is rejected with -EINVAL because
2 >= rcdev->nr_resets, causing miic_probe() to fail.

> @@ -855,6 +860,8 @@ static struct miic_of_data rzn1_miic_of_data = {
>  	.miic_port_start = 1,
>  	.miic_port_last = 5,
>  	.sw_mode_mask = GENMASK(4, 0),
> +	.reset_ids = rzn1_reset_ids,
> +	.reset_count = ARRAY_SIZE(rzn1_reset_ids),
>  	.init_unlock_lock_regs = true,
>  	.miic_write = miic_reg_writel_unlocked,
>  	.type = MIIC_TYPE_RZN1,

[Severity: High]
Will setting reset_count on rzn1_miic_of_data break probe on existing
RZ/N1 device trees that do not have resets and reset-names properties?

miic_reset_control_init() requests the resets with the non-optional
devm_reset_control_bulk_get_exclusive(), which fails with -ENOENT when
resets are absent from the eth-miic node.  Prior to this series, the
renesas,rzn1-miic binding forbade resets, and in-tree r9a06g032.dtsi only
gains them in a later commit in this series ("ARM: dts: renesas:
r9a06g032: Add resets to mii converter"), so probe fails on older DTBs
and at this commit during bisection unless the resets are requested as
optional.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-rzn1-miic-resets-v1-0-feee2bb28bb4@reliablecontrols.com?part=5

  reply	other threads:[~2026-11-20 17:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:57 [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for mii converter Kyle Hendry via B4 Relay
2026-11-19 17:57 ` [PATCH 1/6] dt-bindings: clock: r9a06g032-sysctrl: Document reset cells Kyle Hendry via B4 Relay
2026-11-20  9:23   ` Wolfram Sang
2026-11-20  9:51     ` Philipp Zabel
2026-11-20 11:11       ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 2/6] clk: renesas: r9a06g032: Add reset controller Kyle Hendry via B4 Relay
2026-11-20  9:30   ` Wolfram Sang
2026-11-20 10:00   ` Philipp Zabel
2026-11-20 11:47   ` Wolfram Sang
2026-11-20 17:58   ` sashiko-bot
2026-11-19 17:57 ` [PATCH 3/6] ARM: dts: renesas: r9a06g032: Add #reset-cells to system controller node Kyle Hendry via B4 Relay
2026-11-20  9:32   ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 4/6] dt-bindings: net: pcs: renesas,rzn1-miic: Document rzn1 resets Kyle Hendry via B4 Relay
2026-11-20 11:49   ` Wolfram Sang
2026-11-19 17:57 ` [PATCH 5/6] net: pcs: rzn1-miic: Add resets to rzn1 info structure Kyle Hendry via B4 Relay
2026-11-20 17:58   ` sashiko-bot [this message]
2026-11-19 17:57 ` [PATCH 6/6] ARM: dts: renesas: r9a06g032: Add resets to mii converter Kyle Hendry via B4 Relay
2026-11-20  9:34   ` Wolfram Sang
2026-11-20 17:58   ` sashiko-bot
2026-11-19 22:02 ` [PATCH 0/6] clk: renesas: r9a06g032: Add reset controller to clear resets for " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225762@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khendry@reliablecontrols.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox