From: sashiko-bot@kernel.org
To: "Ingo A. Kubbilun" <ingo.kubbilun@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: add ASUS Vivobook S16 S3607QA (X1P42100)
Date: Fri, 20 Nov 2026 20:26:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-226066@kernel.org> (raw)
In-Reply-To: <20261120201127.90969-3-ingo.kubbilun@gmail.com>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] arm64: dts: qcom: vivobook-s16: missing regulator-always-on
on vreg_l15b_1p8
- [Low] arm64: dts: qcom: SoC CPU thermal zones overridden via path refs
in board DTS
- [Low] arm64: dts: qcom: unsorted pinctrl state nodes in vivobook-s16
tlmm
--
commit cd103c40e0e47c852a865a1b61babe596be2c220
Author: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
arm64: dts: qcom: add ASUS Vivobook S16 S3607QA (X1P42100)
This commit adds the device tree for the ASUS Vivobook S16 S3607QA laptop
based on the Qualcomm Snapdragon X X1-26-100 (X1P42100) SoC.
> diff --git a/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s16.dts b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s16.dts
> new file mode 100644
> index 0000000000000..dba56bd114a00
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s16.dts
[ ... ]
> +&apps_rsc {
> + regulators-0 {
> + compatible = "qcom,pm8550-rpmh-regulators";
> + qcom,pmic-id = "b";
[ ... ]
> + vreg_l12b_1p2: ldo12 {
> + regulator-name = "vreg_l12b_1p2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-always-on;
> + };
[ ... ]
> + vreg_l15b_1p8: ldo15 {
> + regulator-name = "vreg_l15b_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
[Severity: Medium]
Should vreg_l15b_1p8 have regulator-always-on like vreg_l12b_1p2 and the
matching L15B rail on other X1 laptops (such as x1-asus-zenbook-a14.dtsi
and x1-crd.dtsi)?
Because wcn6855-pmu uses vreg_wcn_1p9 for vddio-supply, the audio codecs
(wcd938x, left_spkr, and right_spkr) are the only consumers of
vreg_l15b_1p8 described in DT. If the audio codec drivers defer probe
after enabling their supplies or are unbound, the regulator framework will
drop the use count to zero and disable the 1.8V L15B rail powering shared
on-board components not modeled in DT.
[ ... ]
> +&tlmm {
> + gpio-reserved-ranges = <34 2>, /* Unused */
> + <44 4>, /* SPI (TPM) */
> + <65 1>, /* EC reset */
> + <238 1>; /* UFS Reset */
> +
> + edp_reg_en: edp-reg-en-state {
> + pins = "gpio70";
> + function = "gpio";
> + drive-strength = <16>;
> + bias-disable;
> + };
> +
> + us_euro_hs_sel: us-euro-hs-sel-state {
> + pins = "gpio68";
> + function = "gpio";
> + bias-pull-down;
> + drive-strength = <2>;
> + };
> +
> + wcd_default: wcd-reset-n-active-state {
> + pins = "gpio191";
> + function = "gpio";
> + drive-strength = <16>;
> + bias-disable;
> + output-low;
> + };
> +
> + eusb3_reset_n: eusb3-reset-n-state {
[Severity: Low]
This isn't a bug, but us-euro-hs-sel-state and wcd-reset-n-active-state
are placed ahead of eusb3-reset-n-state instead of in alphabetical order
by node name inside &tlmm.
[ ... ]
> +/*
> + * CPU thermal throttling. hamoa.dtsi only has 115 C critical trips for the
> + * CPU zones, so under sustained load (e.g. make -j8) the SoC ran into the
> + * hardware/EC protection and powered off abruptly. Add a passive trip at
> + * 90 C that lets the thermal core reduce the cluster frequency (scmi-cpufreq
> + * cooling devices), like the GPU zones already do at 95 C.
> + */
> +&{/thermal-zones/cpu0-0-top-thermal} {
> + polling-delay-passive = <250>;
> +
> + trips {
> + cpu0_0_top_alert: cpu-alert {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&cpu0_0_top_alert>;
> + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> +};
[Severity: Low]
Both the TSENS CPU sensors and the SCMI cpufreq cooling devices are
SoC-internal components defined in hamoa.dtsi (where commit 06eadce93697
("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for
CPU") previously removed passive CPU trips in favor of hardware limits
management and board-level skin thermistor cooling maps).
If TSENS-based passive CPU cooling is needed across Purwa/Hamoa machines
without EC or skin thermal control, should these definitions live in a
shared SoC/platform DTSI, or at least reference the &thermal_zones label
from hamoa.dtsi rather than using 20 &{/thermal-zones/...} root-path
overrides in this board DTS?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120201127.90969-1-ingo.kubbilun@gmail.com?part=2
prev parent reply other threads:[~2026-11-20 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 20:10 [PATCH v2 0/2] arm64: dts: qcom: Add ASUS Vivobook S16 S3607QA Ingo A. Kubbilun
2026-11-20 20:10 ` [PATCH v2 1/2] dt-bindings: arm: qcom: add " Ingo A. Kubbilun
2026-11-20 20:10 ` [PATCH v2 2/2] arm64: dts: qcom: add ASUS Vivobook S16 S3607QA (X1P42100) Ingo A. Kubbilun
2026-11-20 20:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226066@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ingo.kubbilun@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox