Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Henri Ommer" <henri@ommer.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e
Date: Sat, 21 Nov 2026 08:32:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-226829@kernel.org> (raw)
In-Reply-To: <20261121082404.24864-3-henri@ommer.net>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] arm64: dts: exynos: off-by-one size 0x3fffffff in
  memory@80000000 node
- [Medium] arm64: dts: exynos: debug and distro flags hardcoded in
  chosen bootargs
- [Low] arm64: dts: exynos: unused downstream fast-slew-rate pinctrl in
  mmc_0
--

commit 3c64e215bef4d1c0f5a772e11d2129cb4345d352
Author: Henri Ommer <henri@ommer.net>

arm64: exynos: Add support for Samsung Galaxy A20e

This commit adds initial device tree support for the Samsung Galaxy A20e
(SM-A202F) based on the Exynos 7885 SoC, covering memory, simple-framebuffer,
GPIO keys, and internal eMMC.

> diff --git a/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts
> new file mode 100644
> index 0000000000000..61f6e5c5341cc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts
> @@ -0,0 +1,132 @@

[ ... ]

> +	chosen {
> +		ranges;
> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		bootargs = "console=tty0 clk_ignore_unused pd_ignore_unused regulator_ignore_unused pmos.nosplash";

[Severity: Medium]
Should clk_ignore_unused, pd_ignore_unused, regulator_ignore_unused, and
pmos.nosplash be dropped from chosen/bootargs?

Hardcoding the *_ignore_unused debug flags globally disables the late
initcalls that gate unused clocks, power domains, and regulators across
the system, and pmos.nosplash is a distribution-specific userspace option
rather than a hardware description.

[ ... ]

> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x80000000 0x3bc00000>,
> +		      <0x0 0xc0000000 0x40000000>,
> +		      <0x8 0x80000000 0x3fffffff>;
> +	};

[Severity: Medium]
Should the size of the third memory bank be 0x40000000 instead of
0x3fffffff?

With #size-cells = <1>, the third cell is a byte size rather than an end
offset.  early_init_dt_add_memory_arch() masks the size with PAGE_MASK
before calling memblock_add(), so 0x3fffffff rounds down and loses the
final page of RAM.

[ ... ]

> +&mmc_0 {

[ ... ]

> +	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8>;
> +	pinctrl-1 = <&sd0_clk_fast_slew_rate_1x>;
> +	pinctrl-2 = <&sd0_clk_fast_slew_rate_2x>;
> +	pinctrl-3 = <&sd0_clk_fast_slew_rate_3x>;
> +	pinctrl-4 = <&sd0_clk_fast_slew_rate_4x>;
> +	pinctrl-names = "default",
> +			"fast-slew-rate-1x",
> +			"fast-slew-rate-2x",
> +			"fast-slew-rate-3x",
> +			"fast-slew-rate-4x";

[Severity: Low]
Are the fast-slew-rate-1x..4x pinctrl states used by the mainline driver?

Neither Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
nor dw_mmc-exynos looks up fast-slew-rate-* pinctrl states, so pinctrl-1
through pinctrl-4 are never selected.  Other Exynos 7885 boards define
only the "default" pinctrl state and place the desired clock drive-strength
pin node directly in pinctrl-0.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121082404.24864-1-henri@ommer.net?part=2

      reply	other threads:[~2026-11-21  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  8:24 [PATCH 0/2] Add Samsung Galaxy A20e support Henri Ommer
2026-11-21  8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer
2026-11-21  8:27   ` sashiko-bot
2026-11-21  8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer
2026-11-21  8:32   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226829@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henri@ommer.net \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox