Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vyacheslav Yurkov" <V.Yurkov.EXT@bruker.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 2/2] clk: gpio: Add driver for GPIO-signalled clocks
Date: Sat, 21 Nov 2026 13:21:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-227063@kernel.org> (raw)
In-Reply-To: <20261121-feature-clock-guard-v10-2-5d449739bb8c@bruker.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] clk: gpio: pass pointer to clk_gpio_enabled_ops in
  CLK_HW_INIT_PARENTS_DATA()
--

commit 89b7f5ec0fd3e779dce65c804661263ec21d8ca2
Author: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>

clk: gpio: Add driver for GPIO-signalled clocks

This commit adds a "gpio-enabled-clock" driver for clocks controlled by
external hardware whose running status is reported through a GPIO line.

> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index df0856a39c8d2..33f251b209a01 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c

[ ... ]

> @@ -241,6 +242,112 @@ static struct platform_driver gpio_clk_driver = {
>  };
>  builtin_platform_driver(gpio_clk_driver);
>  

[ ... ]

> +static const struct clk_ops clk_gpio_enabled_ops = {
> +	.prepare =	clk_gpio_enabled_prepare,
> +	.is_prepared =	clk_gpio_enabled_is_prepared,
> +};
> +
> +static int gpio_enabled_clk_driver_probe(struct platform_device *pdev)
> +{

[ ... ]

> +	clk->hw.init = CLK_HW_INIT_PARENTS_DATA(clk_name, gpio_parent_data,
> +						clk_gpio_enabled_ops, CLK_SET_RATE_PARENT);

[Severity: High]
Should this pass &clk_gpio_enabled_ops instead of clk_gpio_enabled_ops?
CLK_HW_INIT_PARENTS_DATA() initializes struct clk_init_data.ops (const
struct clk_ops *), so passing the struct by value fails to compile.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-feature-clock-guard-v10-0-5d449739bb8c@bruker.com?part=2

      reply	other threads:[~2026-11-21 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 13:16 [PATCH v10 0/2] A proposal to add a gpio-enabled clock driver Vyacheslav Yurkov via B4 Relay
2026-11-21 13:16 ` [PATCH v10 1/2] dt-bindings: clock: Add gpio-enabled-clock Vyacheslav Yurkov via B4 Relay
2026-11-21 13:16 ` [PATCH v10 2/2] clk: gpio: Add driver for GPIO-signalled clocks Vyacheslav Yurkov via B4 Relay
2026-11-21 13:21   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227063@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=V.Yurkov.EXT@bruker.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox