From: sashiko-bot@kernel.org
To: "Vasilij Strassheim" <v.strassheim@linutronix.de>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH net-next v5 3/9] dt-bindings: net: dsa: Add SoC-e SWIP switch function
Date: Sat, 21 Nov 2026 14:53:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-227107@kernel.org> (raw)
In-Reply-To: <20261120-devel-vstrassheim-soce-dsa-ml-v5-3-5de9225715e6@linutronix.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: dsa: soce,swip-switch: port@ nodes bypass port
constraints
--
commit 9b06527d85dea0f657bab899811b3c6f614a7cac
Author: Vasilij Strassheim <v.strassheim@linutronix.de>
dt-bindings: net: dsa: Add SoC-e SWIP switch function
This commit adds a Devicetree binding schema for the Ethernet switch
function integrated into SoC-e SWIP FPGA cores.
> diff --git a/Documentation/devicetree/bindings/net/dsa/soce,swip-switch.yaml b/Documentation/devicetree/bindings/net/dsa/soce,swip-switch.yaml
> new file mode 100644
> index 0000000000000..55232c0f3675e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/soce,swip-switch.yaml
> @@ -0,0 +1,101 @@
[ ... ]
> +$ref: dsa.yaml#/$defs/ethernet-ports
[ ... ]
> + ethernet-ports:
> + type: object
> + patternProperties:
> + '^ethernet-port@[0-9a-f]+$':
> + type: object
> +
> + properties:
> + reg:
> + maximum: 30
> + description: Switch port index, from 0 through 30.
> +
> + phy-mode:
> + enum:
> + - mii
> + - gmii
> + - rmii
> + - rgmii
> + - rgmii-id
> + - rgmii-rxid
> + - rgmii-txid
> +
> + required:
> + - reg
> + - phy-mode
[Severity: Low]
Should this pattern be ^(ethernet-)?port@[0-9a-f]+$?
dsa.yaml#/$defs/ethernet-ports matches both port@<n> and
ethernet-port@<n> child nodes and evaluates them against dsa-port.yaml#,
so a port@<n> child node under ethernet-ports will pass
unevaluatedProperties: false while bypassing the reg maximum and
phy-mode constraints defined here.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-devel-vstrassheim-soce-dsa-ml-v5-0-5de9225715e6@linutronix.de?part=3
next prev parent reply other threads:[~2026-11-21 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 14:52 [PATCH net-next v5 0/9] net: dsa: Add support for SoC-e Ethernet switch IP cores Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 1/9] dt-bindings: vendor-prefixes: Add soce Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 2/9] dt-bindings: net: Add SoC-e SWIP MDIO controller Vasilij Strassheim
2026-11-21 14:53 ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 3/9] dt-bindings: net: dsa: Add SoC-e SWIP switch function Vasilij Strassheim
2026-11-21 14:53 ` sashiko-bot [this message]
2026-11-20 14:52 ` [PATCH net-next v5 4/9] dt-bindings: mfd: Add SoC-e SWIP parent Vasilij Strassheim
2026-11-21 10:19 ` Krzysztof Kozlowski
2026-11-21 14:53 ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 5/9] net: dsa: Add tag handling for SoC-e switches Vasilij Strassheim
2026-11-21 14:53 ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 6/9] net: mdio: Add SoC-e SWIP MDIO controller driver Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 7/9] mfd: soce: Add SWIP core driver Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 8/9] net: dsa: soce: Add basic support for SoC-e SWIP switch Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 9/9] net: dsa: soce: Add VLAN membership table support Vasilij Strassheim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227107@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=v.strassheim@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox