From: sashiko-bot@kernel.org
To: "Fil Dunsky" <filipp.dunsky@gmail.com>
Cc: devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 06/10] dt-bindings: serial: Add Cortina Systems CS7542 UART
Date: Sat, 21 Nov 2026 21:06:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-227370@kernel.org> (raw)
In-Reply-To: <20261122-b4-cs75xx-v8-6-5f971b0dc69c@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: serial: cortina,cs7542-uart: interrupts listed
before clocks
--
commit 9cf5cd80f03458b63f383ce2437badbe51f15cfd
Author: Fil Dunsky <filipp.dunsky@gmail.com>
dt-bindings: serial: Add Cortina Systems CS7542 UART
This commit adds the Device Tree binding schema for the UART found in the
Cortina Systems CS75xx (Goldengate G2) SoCs.
> diff --git a/Documentation/devicetree/bindings/serial/cortina,cs7542-uart.yaml b/Documentation/devicetree/bindings/serial/cortina,cs7542-uart.yaml
> new file mode 100644
> index 0000000000000..2879a71880239
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/cortina,cs7542-uart.yaml
> @@ -0,0 +1,52 @@
[ ... ]
> +properties:
> + compatible:
> + const: cortina,cs7542-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + serial@f0070110 {
> + compatible = "cortina,cs7542-uart";
> + reg = <0xf0070110 0x30>;
> + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&apb_clk>;
> + };
[Severity: Low]
This isn't a bug, but clocks is normally listed before interrupts in
properties, required, and example nodes (compatible, reg, clocks,
interrupts).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-b4-cs75xx-v8-0-5f971b0dc69c@gmail.com?part=6
next prev parent reply other threads:[~2026-11-21 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 21:01 [PATCH v8 00/10] ARM: Add support for Cortina Systems CS75xx and Securifi Almond+ Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 01/10] dt-bindings: vendor-prefixes: Add Securifi Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 02/10] dt-bindings: arm: Add Cortina Systems CS7542 and Securifi Almond+ Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 03/10] dt-bindings: arm: cpus: Add Cortina Systems CS7542 enable method Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 04/10] ARM: goldengate: Add support for the CS75xx SoC family Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 05/10] ARM: debug: Add Cortina Systems CS75xx UART0 support Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 06/10] dt-bindings: serial: Add Cortina Systems CS7542 UART Fil Dunsky via B4 Relay
2026-11-21 21:06 ` sashiko-bot [this message]
2026-11-21 21:01 ` [PATCH v8 07/10] tty: serial: Add Cortina UART driver Fil Dunsky via B4 Relay
2026-11-21 21:10 ` sashiko-bot
2026-11-21 21:01 ` [PATCH v8 08/10] ARM: dts: cortina: Add CS7542 SoC and Securifi Almond+ board Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 09/10] ARM: multi_v7_defconfig: Enable Cortina Systems CS75xx support Fil Dunsky via B4 Relay
2026-11-21 21:01 ` [PATCH v8 10/10] MAINTAINERS: Add entry for Cortina Systems CS75xx Fil Dunsky via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227370@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=filipp.dunsky@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox