From: sashiko-bot@kernel.org
To: EMCP333 <emcp@enser.io>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 2/3] Input: synaptics-rmi4 - keep an I2C device that may wake the system powered
Date: Sun, 22 Nov 2026 05:23:07 +0000 [thread overview]
Message-ID: <sashiko-outbox-227741@kernel.org> (raw)
In-Reply-To: <20261122-b4-rmi4-wakeup-v1-2-1b662be4a9d6@enser.io>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] Input: synaptics-rmi4 - missing Fixes trailer for commit
946c8432aab0
--
commit 83b2656443640f5726e0dae2d6e9d52155752d68
Author: EMCP333 <emcp@enser.io>
> Input: synaptics-rmi4 - keep an I2C device that may wake the system powered
>
> rmi_i2c_suspend() arms the attention interrupt for wakeup through
> rmi_driver_suspend(..., true) and then disables the vdd and vio supplies.
> Unpowered, the controller cannot report a touch, so the wakeup it has just
> armed can never come from the user. Where the attention line is pulled up
> from the switched I/O supply, cutting that supply also pulls the line
> low, and that falling edge ends the suspend by itself.
>
> On a OnePlus 6T (S3706B, attention on a falling-edge GPIO, vio from a
> GPIO-controlled fixed regulator) with the touchscreen marked as a wakeup
> source, every s2idle ended within 3 to 4 seconds with nobody touching the
> phone, with one attention interrupt per suspend.
>
> Keep the supplies on in system suspend when the device may wake the
> system, as edt-ft5x06 does, and skip the matching re-enable and startup
> delay on resume. A device that may not wake is powered down as before.
>
> Tested on a OnePlus 6T on v7.4-rc3 with 'wakeup-source' on the
> touchscreen node. With wakeup enabled and nothing touching the phone,
> "rtcwake -m freeze -s 30" slept the full 30 seconds with no attention
> interrupt (2 of 2), and a double-tap woke it (2 of 2, 120 second RTC
> fallback). With wakeup disabled the supplies are cut as before and it
> slept until the RTC (2 of 2).
>
> The code and this changelog were prepared with the help of an AI coding
> assistant. The submitter has reviewed both and takes responsibility for
> them.
>
> Signed-off-by: EMCP333 <emcp@enser.io>
[Severity: Low]
This fixes a bug introduced when regulator support was added to
rmi_i2c_suspend() and rmi_i2c_resume(). Should the commit message include:
Fixes: 946c8432aab0 ("Input: synaptics-rmi4 - support regulator supplies")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-b4-rmi4-wakeup-v1-0-1b662be4a9d6@enser.io?part=2
next prev parent reply other threads:[~2026-11-22 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 5:13 [PATCH 0/3] Touchscreen wakeup for the OnePlus 6 and 6T EMCP333 via B4 Relay
2026-11-22 5:13 ` [PATCH 1/3] dt-bindings: input: syna,rmi4: Document wakeup-source EMCP333 via B4 Relay
2026-11-22 5:13 ` [PATCH 2/3] Input: synaptics-rmi4 - keep an I2C device that may wake the system powered EMCP333 via B4 Relay
2026-11-22 5:23 ` sashiko-bot [this message]
2026-11-22 6:42 ` Erik Peterson
2026-11-22 5:13 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark the touchscreen as a wakeup source EMCP333 via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227741@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=emcp@enser.io \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox