Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Yang" <mmyangfl@gmail.com>, linux-watchdog@vger.kernel.org
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: watchdog: Add HiSilicon STB watchdog binding
Date: Sun, 22 Nov 2026 07:03:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-227779@kernel.org> (raw)
In-Reply-To: <20261122065549.3265519-2-mmyangfl@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: watchdog: redundant word binding in commit subject
- [Low] dt-bindings: watchdog: non-canonical property order in example
  node
--

commit a1622b56fb454eac20ec415b3fb13ffbe0760e8a
Author: David Yang <mmyangfl@gmail.com>

dt-bindings: watchdog: Add HiSilicon STB watchdog binding

This commit adds a Device Tree binding schema for the watchdog controller
found on HiSilicon STB SoCs.

> dt-bindings: watchdog: Add HiSilicon STB watchdog binding

[Severity: Low]
The "dt-bindings:" prefix already states that the patch adds a binding, so
"binding" at the end of the subject is redundant and can be dropped:
"dt-bindings: watchdog: Add HiSilicon STB watchdog".

> diff --git a/Documentation/devicetree/bindings/watchdog/hisilicon,histb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hisilicon,histb-wdt.yaml
> new file mode 100644
> index 0000000000000..c0a8ccdb482a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/hisilicon,histb-wdt.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    watchdog@8a2c000 {
> +        compatible = "hisilicon,hi3798cv200-wdt", "hisilicon,histb-wdt";
> +        reg = <0x8a2c000 0x1000>;
> +        interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&crg 0>;
> +    };

[Severity: Low]
In the example node, clocks should be listed before interrupts to follow
the canonical property order used in the properties list above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122065549.3265519-1-mmyangfl@gmail.com?part=1

  reply	other threads:[~2026-11-22  7:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  6:55 [PATCH 0/4] watchdog: histb: Add HiSilicon STB watchdog driver David Yang
2026-11-22  6:55 ` [PATCH 1/4] dt-bindings: watchdog: Add HiSilicon STB watchdog binding David Yang
2026-11-22  7:03   ` sashiko-bot [this message]
2026-11-22  6:55 ` [PATCH 2/4] watchdog: histb: Add HiSilicon STB watchdog driver David Yang
2026-11-22  6:55 ` [PATCH 3/4] arm64: dts: hisilicon: hi3798cv200: Add watchdog node David Yang
2026-11-22  6:55 ` [PATCH 4/4] MAINTAINERS: Add HiSilicon STB drivers entry David Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227779@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mmyangfl@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox