Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Artem Novak" <artem122novak@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero
Date: Sun, 22 Nov 2026 10:02:10 +0000	[thread overview]
Message-ID: <sashiko-outbox-227881@kernel.org> (raw)
In-Reply-To: <20261122095225.200916-2-artem122novak@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] ARM: dts: bcm2835: loss of leds and led_act symbols in
  bcm2835-rpi-zero.dtb
- [Low] ARM: dts: bcm2835: redundant inlining of
  bcm283x-rpi-led-deprecated.dtsi
--

commit 739b5e27f1887a8552cb53d11c780143b2a0ef69
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero

This commit replaces the included bcm283x-rpi-led-deprecated.dtsi fragment
in bcm2835-rpi-zero.dts with an inline gpio-leds node for the ACT LED.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> index 539c19c10946c..9364695055b4e 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> @@ -7,7 +7,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-usb-otg.dtsi"
>  
>  / {
> @@ -101,8 +100,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +/ {
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-act {

[Severity: Medium]
Does dropping the leds: and led_act: node labels here remove the leds and
led_act entries from /__symbols__ in bcm2835-rpi-zero.dtb?

arch/arm/boot/dts/broadcom/Makefile compiles bcm2835-rpi-zero.dtb with -@
(DTC_FLAGS_bcm2835-rpi-zero := -@), and bcm283x-rpi-led-deprecated.dtsi
defined leds: leds and led_act: led-act.  Without those labels, Device
Tree overlays and bootloader dtparam overrides targeting &leds or &led_act
will fail to resolve on Raspberry Pi Zero.

> +			label = "ACT";
> +			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };

[Severity: Low]
Does open-coding bcm283x-rpi-led-deprecated.dtsi here defeat the purpose
of 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")?

What is deprecated in Documentation/devicetree/bindings/leds/common.yaml
is the label = "ACT" property (in favor of function and color), which has
to be kept on existing boards to preserve the /sys/class/leds/ACT
userspace interface.  Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT
LED into separate dtsi") moved that legacy node into
bcm283x-rpi-led-deprecated.dtsi so existing boards share one definition
while new boards do not inherit it; inlining the same label = "ACT"
definition into a second root / { ... }; block in the middle of the
phandle overrides duplicates the shared fragment without removing the
deprecated property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122095225.200916-1-artem122novak@gmail.com?part=1

  reply	other threads:[~2026-11-22 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
2026-11-22 10:02   ` sashiko-bot [this message]
2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227881@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=artem122novak@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox