From: sashiko-bot@kernel.org
To: "Sasha Finkelstein" <k@chaosmail.tech>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v2 5/5] phy: apple: atc: Split generation-specific code
Date: Sun, 22 Nov 2026 12:35:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-227927@kernel.org> (raw)
In-Reply-To: <20261122-t8122-phy-v2-5-8d5c8fdf31ba@chaosmail.tech>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] phy: apple: atc: missing linux/bitfield.h include for
FIELD_PREP()
--
commit e397fb823d5ae453512b167eed88b2e91bd53da3
Author: Sasha Finkelstein <k@chaosmail.tech>
phy: apple: atc: Split generation-specific code
This commit splits the T8103 and T8122 hardware generation-specific code
out of drivers/phy/apple/atc.c into atc-t8103.c, atc-t8122.c, and a shared
atc.h header.
> diff --git a/drivers/phy/apple/atc.h b/drivers/phy/apple/atc.h
> new file mode 100644
> index 0000000000000..d6a608c677696
> --- /dev/null
> +++ b/drivers/phy/apple/atc.h
> @@ -0,0 +1,806 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> +
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/reset-controller.h>
> +
> +#ifndef __ATC_H__
> +#define __ATC_H__
[Severity: Medium]
Should atc.h (or atc-t8103.c and atc-t8122.c) include <linux/bitfield.h>?
Both atc-t8103.c and atc-t8122.c call FIELD_PREP(), such as in
atcphy_configure_pipehandler_usb3_host_t8103() and
atcphy_configure_pipehandler_usb3_host_t8122(), which previously relied on
the <linux/bitfield.h> include in atc.c. On arm64, <asm/sysreg.h> pulls
in <linux/bitfield.h> transitively, but PHY_APPLE_ATC enables
CONFIG_COMPILE_TEST on other 64-bit architectures (such as x86_64) where
the build fails with an implicit declaration of FIELD_PREP().
Also, the #include directives at the top of atc.h sit outside the
__ATC_H__ include guard.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-t8122-phy-v2-0-8d5c8fdf31ba@chaosmail.tech?part=5
prev parent reply other threads:[~2026-11-22 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 12:27 [PATCH v2 0/5] phy: apple: atc: Add M3 support Sasha Finkelstein
2026-11-22 12:27 ` [PATCH v2 1/5] dt-bindings: phy: atcphy: Add M3 series Sasha Finkelstein
2026-11-22 12:27 ` [PATCH v2 2/5] soc: apple: tunable: Allow passing NULL to tunable_apply Sasha Finkelstein
2026-11-22 12:27 ` [PATCH v2 3/5] phy: apple: atc: Add initial M3 series support Sasha Finkelstein
2026-11-22 12:35 ` sashiko-bot
2026-11-22 12:28 ` [PATCH v2 4/5] phy: apple: atc: Add T8122 DisplayPort support Sasha Finkelstein
2026-11-22 12:44 ` sashiko-bot
2026-11-22 12:28 ` [PATCH v2 5/5] phy: apple: atc: Split generation-specific code Sasha Finkelstein
2026-11-22 12:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227927@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k@chaosmail.tech \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox