Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maíra Canal" <mcanal@igalia.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] drm/v3d: Remove V3D 3.3 and 4.1 support
Date: Sun, 22 Nov 2026 15:58:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-228068@kernel.org> (raw)
In-Reply-To: <20261122-v3d-remove-33-41-v1-2-52152b454ad8@igalia.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] drm/v3d: V3D 3.x OVRTMUOUT bit reported on V3D 4.2 in
  v3d_v3d_debugfs_ident()
- [Low] drm/v3d: stale V3D 3.3 and 4.1 deprecation notice in v3d_drv.c
  DOC comment
--

commit 24570297f583283eb9b4a58e9c2e78e6081f77f1
Author: Maíra Canal <mcanal@igalia.com>

drm/v3d: Remove V3D 3.3 and 4.1 support

This commit removes support for the deprecated V3D 3.3 and V3D 4.1 GPUs,
along with their device tree compatibles, GCA and bridge reset registers,
and V3D 3.x performance counter handling.

> diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c
> index 634cc796ba232..938622c730d04 100644
> --- a/drivers/gpu/drm/v3d/v3d_debugfs.c
> +++ b/drivers/gpu/drm/v3d/v3d_debugfs.c

[ ... ]

> @@ -210,8 +194,6 @@ static int v3d_v3d_debugfs_ident(struct seq_file *m, void *unused)
>  		if (v3d->ver <= V3D_GEN_42) {
>  			seq_printf(m, "  BCG int:      %d\n",
>  				   (ident2 & V3D_IDENT2_BCG_INT) != 0);
> -		}
> -		if (v3d->ver < V3D_GEN_41) {
>  			seq_printf(m, "  Override TMU: %d\n",
>  				   (misccfg & V3D_MISCCFG_OVRTMUOUT) != 0);
>  		}

[Severity: Low]
Should the "Override TMU" line (along with the misccfg read in
v3d_v3d_debugfs_ident() and V3D_MISCCFG_OVRTMUOUT in v3d_regs.h) be removed
instead of folded into the v3d->ver <= V3D_GEN_42 block?

As noted in commit a7dde1b7a5c9 ("drm/v3d: Don't try to set OVRTMUOUT on V3D
4.x."), V3D_MISCCFG_OVRTMUOUT only existed on V3D 3.x, and this patch drops
the corresponding write from v3d_init_core().  Keeping it here causes
v3d_ident on V3D 4.2 to report a V3D 3.x bit that does not exist on V3D 4.x
hardware, and the new "/* Only V3D 4.x */" comment above
V3D_MISCCFG_OVRTMUOUT in v3d_regs.h is also inaccurate.

[ ... ]

> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index b790be8a7face..0551e9abf17ea 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c

[ ... ]

> @@ -421,18 +392,6 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
>  	 */
>  	WARN_ON(v3d->ver != gen);
>  
> -	/* V3D 3.3 and V3D 4.1 has had no in-tree userspace since Mesa
> -	 * dropped support in 2024 (MR#25851) and they have no known users.
> -	 * Due to that, support is scheduled for removal in the next release.
> -	 */
> -	if (v3d->ver <= V3D_GEN_41) {
> -		dev_warn(dev,
> -			 "V3D %u.%u support is deprecated and will be removed "
> -			 "in the next kernel release. If you rely on this hardware, "
> -			 "please report it to dri-devel@lists.freedesktop.org.\n",
> -			 v3d->ver / 10, v3d->ver % 10);
> -	}
> -
>  	v3d->cores = V3D_GET_FIELD(ident1, V3D_HUB_IDENT1_NCORES);

[Severity: Low]
Should the deprecation paragraph in the "DOC: Broadcom V3D Graphics Driver"
comment at the top of drivers/gpu/drm/v3d/v3d_drv.c also be removed now that
V3D 3.3 and 4.1 support is gone?

drivers/gpu/drm/v3d/v3d_drv.c:
    ...
     * This driver supports the Broadcom V3D 4.2 and 7.1 GPUs.
     *
     * Support for V3D 3.3 and 4.1 GPUs is deprecated and it will be removed
     * in the next kernel release.
    ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-v3d-remove-33-41-v1-0-52152b454ad8@igalia.com?part=2

      reply	other threads:[~2026-11-22 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 15:47 [PATCH 0/2] drm/v3d: Remove V3D 3.3 and 4.1 support Maíra Canal
2026-11-22 15:47 ` [PATCH 1/2] dt-bindings: gpu: v3d: Require resets for BCM2711 and BCM2712 Maíra Canal
2026-11-22 15:47 ` [PATCH 2/2] drm/v3d: Remove V3D 3.3 and 4.1 support Maíra Canal
2026-11-22 15:58   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228068@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mcanal@igalia.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox