Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Srinivas Kandagatla" <srinivas.kandagatla@oss.qualcomm.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 08/24] ASoC: codecs: wsa884x: register the die temperature as a thermal zone
Date: Sun, 22 Nov 2026 16:28:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-228100@kernel.org> (raw)
In-Reply-To: <20261122161437.5994-9-srinivas.kandagatla@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [High] ASoC: codecs: wsa884x: const ops mismatch in wsa884x_probe()
  when THERMAL=n
- [Medium] ASoC: codecs: wsa884x: duplicate hwmon device registered in
  wsa884x_probe()
- [Medium] ASoC: codecs: wsa884x: missing hw_init check in
  wsa884x_get_temp()
- [Low] ASoC: codecs: wsa884x: 0 degC cache sentinel collision in
  wsa884x_get_temp()
--

commit 504ad1ac146d2450131667d4fbd39ad8f105450a
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

ASoC: codecs: wsa884x: register the die temperature as a thermal zone

This commit registers a tripless thermal zone for the WSA884x codec die
temperature sensor and returns -EAGAIN or THERMAL_TEMP_INVALID when a
valid reading is not available.

> diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c
> index 91aa004d7137b..e56c848cbfce6 100644
> --- a/sound/soc/codecs/wsa884x.c
> +++ b/sound/soc/codecs/wsa884x.c
[ ... ]
> @@ -1935,8 +1936,10 @@ static int wsa884x_get_temp(struct wsa884x_priv *wsa884x, long *temp)
>  	if (wsa884x->pa_on) {
>  		/*
>  		 * Reading temperature is possible only when Power Amplifier is
> -		 * off. Report last cached data.
> +		 * off. Report last cached data if we have one, -EAGAIN otherwise.
>  		 */
> +		if (!wsa884x->temperature)
> +			return -EAGAIN;
>  		*temp = wsa884x->temperature * 1000;
>  		return 0;
>  	}

[Severity: Low]
Can this treat a valid cached reading of 0 degC as uncached?

wsa884x_get_temp() accepts measured temperatures in
[WSA884X_LOW_TEMP_THRESHOLD, WSA884X_HIGH_TEMP_THRESHOLD] ([-10, 150]
degC) and stores them in wsa884x->temperature.  If 0 degC is measured
before the PA turns on, later reads while pa_on is true hit
!wsa884x->temperature and return -EAGAIN (reporting THERMAL_TEMP_INVALID
to the thermal zone).  Also, because wsa884x->temperature in struct
wsa884x_priv is an unsigned int, negative readings in [-10, -1] degC wrap
and are multiplied as unsigned 32-bit values before being widened to long.

> @@ -2058,6 +2061,42 @@ static const struct hwmon_chip_info wsa884x_hwmon_chip_info = {
>  	.info	= wsa884x_hwmon_info,
>  };
>  
> +static int wsa884x_tz_get_temp(struct thermal_zone_device *tz, int *temp_mdeg)
> +{
> +	struct wsa884x_priv *wsa884x = thermal_zone_device_priv(tz);
> +	long mdeg;
> +	int ret;
> +
> +	/*
> +	 * OTP trims read back as zero until the codec is initialised. Report
> +	 * no reading rather than -EAGAIN, which makes the core poll the zone.
> +	 */
> +	if (!wsa884x->hw_init) {
> +		*temp_mdeg = THERMAL_TEMP_INVALID;
> +		return 0;
> +	}

[Severity: Medium]
Should the !wsa884x->hw_init check live inside wsa884x_get_temp() under
wsa884x->sp_lock instead?

The commit message notes that before the codec is initialized, hwmon
should receive -EAGAIN, but wsa884x_hwmon_read() calls wsa884x_get_temp()
directly without this guard.  If userspace reads hwmon while hw_init is
false, wsa884x_get_temp() calls pm_runtime_resume_and_get(), which takes
the regmap out of cache-only mode in wsa884x_runtime_resume() if the
device has autosuspended while still SDW_SLAVE_UNATTACHED.  On initial
unattached reads the OTP registers read as zero, hitting d1 == d2 and
returning -EINVAL instead of -EAGAIN; if the codec was previously attached
and later unattached, cached OTP values combined with a failed volatile
dmeas read (0) compute a bogus temperature.  Checking !wsa884x->hw_init
in wsa884x_get_temp() under sp_lock and returning -EAGAIN covers both
hwmon and the thermal zone and avoids racing with wsa884x_update_status().

[ ... ]

> @@ -2194,6 +2233,35 @@ static int wsa884x_probe(struct sdw_slave *pdev,
>  	if (ret)
>  		return ret;
>  
> +	if (IS_REACHABLE(CONFIG_THERMAL)) {
> +		char tz_name[THERMAL_NAME_LENGTH];
> +		struct thermal_zone_device *tz;
> +
> +		/*
> +		 * Register after runtime PM is enabled, as the zone is read
> +		 * right away. dev_name() is too long for a zone name.
> +		 */
> +		scnprintf(tz_name, sizeof(tz_name), "wsa-%d-%u",
> +			  pdev->bus->id, pdev->id.unique_id);
> +		tz = thermal_tripless_zone_device_register(tz_name,
> +							   wsa884x,
> +							   &wsa884x_tz_ops,
> +							   NULL);

[Severity: High]
Does this fail to build when CONFIG_THERMAL is disabled (or when
CONFIG_THERMAL=m and CONFIG_SND_SOC_WSA884X=y)?

wsa884x_tz_ops is declared const, and IS_REACHABLE(CONFIG_THERMAL) is a C
if condition, so the call is still type-checked when the !CONFIG_THERMAL
stub in include/linux/thermal.h is active:

include/linux/thermal.h:
static inline struct thermal_zone_device *thermal_tripless_zone_device_register(
					const char *type,
					void *devdata,
					struct thermal_zone_device_ops *ops,
					const struct thermal_zone_params *tzp)
{ return ERR_PTR(-ENODEV); }

Because the stub's ops parameter is not const, passing &wsa884x_tz_ops
triggers -Werror=discarded-qualifiers.

[Severity: Medium]
Does passing NULL for tzp in thermal_tripless_zone_device_register()
register a duplicate hwmon device for this sensor?

wsa884x_probe() already registers a dedicated hwmon device via
devm_hwmon_device_register_with_info().  When tzp is NULL,
thermal_zone_device_register_with_trips() sees !tz->tzp ||
!tz->tzp->no_hwmon and calls thermal_add_hwmon_sysfs() under
CONFIG_THERMAL_HWMON=y, exposing two hwmon devices for the same die
temperature sensor and causing userspace hwmon scanners to wake the codec
and run the register sequence twice per scan.  Passing a struct
thermal_zone_params with .no_hwmon = true (or .no_hwmon =
IS_REACHABLE(CONFIG_HWMON)) avoids the duplicate registration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122161437.5994-1-srinivas.kandagatla@oss.qualcomm.com?part=8

  reply	other threads:[~2026-11-22 16:28 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 17:14 [RFC PATCH 00/23] ASoC: qcom: AudioReach Active speaker protection for WSA884x Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 01/23] ASoC: soc-core: allow default ch_maps on links with more than 8 DAIs Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:04     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 02/23] ASoC: soc-pcm: add multi_direction_codecs link flag Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:04     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 03/23] ASoC: qcom: sdw: add per-direction stream runtimes for multi_direction links Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:04     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 04/23] ASoC: dt-bindings: qcom,wsa8840: allow one sound DAI cell Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 05/23] ASoC: codecs: wsa884x: add VI sense capture DAI Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:03     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 06/23] ASoC: codecs: wsa884x: register the die temperature as a thermal zone Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 07/23] ASoC: qcom: audioreach: add control link support to graphs Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 08/23] ASoC: qcom: audioreach: run VI module in calibration mode with per-speaker events Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:04     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 09/23] ASoC: qcom: q6apm-dai: add S32_LE format support Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 10/23] ASoC: qcom: audioreach: support up to four speakers in VI feedback Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 11/23] ASoC: qcom: audioreach: cache VI calibration results per speaker Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 12/23] ASoC: qcom: audioreach: make the speaker protection operation mode configurable Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 13/23] ASoC: qcom: audioreach: send cached R0/T0 to the VI module in normal mode Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 14/23] ASoC: qcom: audioreach: send static cfg blobs to speaker protection modules Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 15/23] ASoC: qcom: audioreach: add speaker protection mixer controls Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 16/23] ASoC: qcom: audioreach: pin SPEAKER_PROTECTION_VI media format Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 17/23] ASoC: qcom: audioreach: add live speaker temperature (T0) readback Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 18/23] ASoC: qcom: audioreach: add speaker protection calibration state control Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 19/23] ASoC: qcom: audioreach: keep the last VI calibration result until the DSP reports Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 20/23] ASoC: qcom: x1e80100: carry WSA VI feedback on the WSA Playback BE link Srinivas Kandagatla
2026-11-15 17:36   ` Mark Brown
2026-11-15 21:03     ` Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 21/23] ASoC: qcom: x1e80100: register WSA speaker thermal zones for speaker protection Srinivas Kandagatla
2026-10-23 17:14 ` [RFC PATCH 22/23] arm64: dts: qcom: glymur-crd: add WSA speaker protection VI feedback Srinivas Kandagatla
2026-10-28 13:38   ` Konrad Dybcio
2026-10-28 21:59     ` Srinivas Kandagatla
2026-10-29  8:17       ` Konrad Dybcio
2026-10-23 17:14 ` [RFC PATCH 23/23] arm64: dts: qcom: mahua-t14s: " Srinivas Kandagatla
2026-10-28 12:39 ` [RFC PATCH 00/23] ASoC: qcom: AudioReach Active speaker protection for WSA884x Mark Brown
2026-10-28 16:31 ` Fabian Renn-Giles
2026-10-28 21:56   ` Srinivas Kandagatla
2026-11-15 22:07     ` Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 00/24] ASoC: qcom: AudioReach Active speaker protection for WSA88xx Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 01/24] ASoC: soc-core: always allocate default ch_maps Srinivas Kandagatla
2026-11-22 16:31   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 02/24] ASoC: soc-pcm: add multi_direction_codecs link flag Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 03/24] ASoC: soc-dai: export snd_soc_dai_stream_valid Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 04/24] ASoC: qcom: sdw: add per-direction stream runtimes for multi_direction links Srinivas Kandagatla
2026-11-22 16:38   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 05/24] ASoC: dt-bindings: qcom,wsa8840: allow one sound DAI cell Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 06/24] ASoC: codecs: wsa884x: add VI sense capture DAI Srinivas Kandagatla
2026-11-22 16:28   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 07/24] ASoC: codecs: wsa883x: " Srinivas Kandagatla
2026-11-22 16:28   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 08/24] ASoC: codecs: wsa884x: register the die temperature as a thermal zone Srinivas Kandagatla
2026-11-22 16:28   ` sashiko-bot [this message]
2026-11-22 16:14 ` [PATCH v2 09/24] ASoC: qcom: audioreach: add control link support to graphs Srinivas Kandagatla
2026-11-22 16:32   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 10/24] ASoC: qcom: audioreach: run VI module in calibration mode with per-speaker events Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 11/24] ASoC: qcom: q6apm-dai: add S32_LE format support Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 12/24] ASoC: qcom: audioreach: cache VI calibration results per speaker Srinivas Kandagatla
2026-11-22 16:22   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 13/24] ASoC: qcom: audioreach: add speaker protection calibration trigger infrastructure Srinivas Kandagatla
2026-11-22 16:31   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 14/24] ASoC: qcom: audioreach: send cached R0/T0 to the VI module in normal mode Srinivas Kandagatla
2026-11-22 16:28   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 15/24] ASoC: qcom: audioreach: send static cfg blobs to speaker protection modules Srinivas Kandagatla
2026-11-22 16:31   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 16/24] ASoC: qcom: audioreach: add speaker protection mixer controls Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 17/24] ASoC: qcom: audioreach: pin SPEAKER_PROTECTION_VI media format Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 18/24] ASoC: qcom: audioreach: add live speaker temperature (T0) readback Srinivas Kandagatla
2026-11-22 16:37   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 19/24] ASoC: qcom: audioreach: add speaker protection calibration state control Srinivas Kandagatla
2026-11-22 16:37   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 20/24] ASoC: qcom: x1e80100: carry WSA VI feedback on the WSA Playback BE link Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 21/24] ASoC: qcom: x1e80100: register WSA speaker thermal zones for speaker protection Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 22/24] arm64: dts: qcom: glymur-crd: add WSA speaker protection VI feedback Srinivas Kandagatla
2026-11-22 16:39   ` sashiko-bot
2026-11-22 16:14 ` [PATCH v2 23/24] arm64: dts: qcom: mahua-t14s: " Srinivas Kandagatla
2026-11-22 16:14 ` [PATCH v2 24/24] arm64: dts: qcom: x1e78100-t14s: " Srinivas Kandagatla
2026-11-22 16:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228100@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox