From: sashiko-bot@kernel.org
To: "Mohammad Rafi Shaik" <mohammad.rafi.shaik@oss.qualcomm.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v7 9/9] ASoC: qcom: lpass: Add support for Hawi
Date: Sun, 22 Nov 2026 18:57:31 +0000 [thread overview]
Message-ID: <sashiko-outbox-228214@kernel.org> (raw)
In-Reply-To: <20261123-add_shikra_support-v7-9-7bf3aa089fc6@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ASoC: qcom: lpass: rx_macro_probe() and va_macro_probe() omit
Hawi clocks
--
commit b322e6f1ecfd843ff25b62f5054d026e946526ee
Author: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
ASoC: qcom: lpass: Add support for Hawi
This commit adds the qcom,hawi-lpass-rx-macro and qcom,hawi-lpass-va-macro
compatibles to the LPASS RX and VA macro codec drivers, reusing the sm8550
match data.
> diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
> index b3adb32f7d332..09ea4240196c9 100644
> --- a/sound/soc/codecs/lpass-rx-macro.c
> +++ b/sound/soc/codecs/lpass-rx-macro.c
> @@ -3997,6 +3997,8 @@ static const struct of_device_id rx_macro_dt_match[] = {
> .data = (void *)LPASS_MACRO_FLAG_HAS_NPL_CLOCK,
> }, {
> .compatible = "qcom,sm8550-lpass-rx-macro",
> + }, {
> + .compatible = "qcom,hawi-lpass-rx-macro",
> }, {
> .compatible = "qcom,sc8280xp-lpass-rx-macro",
> .data = (void *)LPASS_MACRO_FLAG_HAS_NPL_CLOCK,
> diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
> index 8ed8420d7185b..8e0c38517a5ff 100644
> --- a/sound/soc/codecs/lpass-va-macro.c
> +++ b/sound/soc/codecs/lpass-va-macro.c
> @@ -2195,6 +2195,7 @@ static const struct of_device_id va_macro_dt_match[] = {
> { .compatible = "qcom,sm8250-lpass-va-macro", .data = &sm8250_va_data },
> { .compatible = "qcom,sm8450-lpass-va-macro", .data = &sm8450_va_data },
> { .compatible = "qcom,sm8550-lpass-va-macro", .data = &sm8550_va_data },
> + { .compatible = "qcom,hawi-lpass-va-macro", .data = &sm8550_va_data },
> { .compatible = "qcom,sc8280xp-lpass-va-macro", .data = &sm8450_va_data },
> { .compatible = "qcom,shikra-lpass-va-macro", .data = &shikra_va_data },
> {}
[Severity: High]
As reported by Ajay Kumar Nandam on v4 [1], do rx_macro_probe() and
va_macro_probe() also need to acquire and enable the lpr and
heartbeatpulse clocks defined for Hawi?
Commit "ASoC: dt-bindings: qcom: Add Hawi LPASS macro codecs" specifies
clock-names as mclk, lpr, dcodec, and fsgen for qcom,hawi-lpass-rx-macro
(replacing macro with lpr), and mclk, lpr, dcodec, and heartbeatpulse for
qcom,hawi-lpass-va-macro.
Both drivers request clocks by name in rx_macro_probe() and
va_macro_probe() and enable them in rx_macro_enable_clocks() and
va_macro_enable_clocks(), but they only look up the optional "macro" clock
and never request "lpr" or "heartbeatpulse". On a compliant Hawi or Maili
Device Tree, rx->macro and va->macro resolve to NULL, leaving the LPASS
sleep-disable vote (lpr) and the VA heartbeatpulse clock disabled during
register accesses in probe and runtime PM resume.
[1] https://lore.kernel.org/r/6f2afa91-6355-45f8-b6be-6b556c679813@oss.qualcomm.com
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261123-add_shikra_support-v7-0-7bf3aa089fc6@oss.qualcomm.com?part=9
prev parent reply other threads:[~2026-11-22 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 18:41 [PATCH v7 0/9] ASoC: qcom: Add shikra and Hawi LPASS macro support Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 1/9] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro codecs Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 2/9] ASoC: qcom: lpass-macro-common: Add missing v2.9 version string Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 3/9] ASoC: qcom: lpass-rx-macro: Add shikra compatible Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 4/9] ASoC: qcom: lpass-va-macro: " Mohammad Rafi Shaik
2026-11-22 19:01 ` sashiko-bot
2026-11-22 18:41 ` [PATCH v7 5/9] ASoC: qcom: lpass-va-macro: Add SoundWire microphone support Mohammad Rafi Shaik
2026-11-22 18:55 ` sashiko-bot
2026-11-22 18:41 ` [PATCH v7 6/9] ASoC: dt-bindings: qcom: Add Hawi LPASS macro codecs Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 7/9] ASoC: dt-bindings: qcom: Add Maili " Mohammad Rafi Shaik
2026-11-22 18:41 ` [PATCH v7 8/9] ASoC: qcom: lpass-tx-macro: Add support for Hawi Mohammad Rafi Shaik
2026-11-22 19:00 ` sashiko-bot
2026-11-22 18:41 ` [PATCH v7 9/9] ASoC: qcom: lpass: " Mohammad Rafi Shaik
2026-11-22 18:57 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-228214@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox