Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Venkat Yadlapati" <venkat.yadlapati@yahoo.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] dt-bindings: usb: snps,dwc3-common: Document usb-psy-name
Date: Sun, 22 Nov 2026 19:31:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-228257@kernel.org> (raw)
In-Reply-To: <20261123-vantage-dwc3-v2-1-2e741a834411@yahoo.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: usb: snps,dwc3-common: usb-psy-name exposes
  Linux psy name
--

commit 27eb59afa8c6a2fd9ecc95737f8c70278b4ddb0d
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

dt-bindings: usb: snps,dwc3-common: Document usb-psy-name

This commit documents the usb-psy-name string property in the common
Synopsys DesignWare USB3 controller Devicetree binding schema.

> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml
> index 6c0b8b6538246..41e8537b34d50 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml
> @@ -51,6 +51,13 @@ properties:
>        - items:
>            pattern: "^usb(2-([0-9]|1[0-4])|3-[0-3])$"
>  
> +  usb-psy-name:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Name of the power supply that is told the current the USB host
> +      grants to the device (e.g. after enumeration), so the charger can
> +      draw it.
> +
>    snps,usb2-lpm-disable:
>      description: Indicate if we don't want to enable USB2 HW LPM for host
>        mode.

[Severity: Medium]
Should a Linux power_supply registration name string be part of the
Devicetree binding ABI?

dwc3_get_usb_power_supply() reads usb-psy-name via
device_property_read_string() and passes it to power_supply_get_by_name(),
which matches against the kernel-internal power_supply_desc.name string
(such as "qcom-battmgr-usb") rather than describing hardware.  Per
Documentation/devicetree/bindings/writing-bindings.rst, Devicetree bindings
should reference other devices via phandles (such as power-supplies or a
USB connector graph link) rather than driver or device name strings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261123-vantage-dwc3-v2-1-2e741a834411@yahoo.com?part=1

      reply	other threads:[~2026-11-22 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 19:20 [PATCH v2] dt-bindings: usb: snps,dwc3-common: Document usb-psy-name Venkat Yadlapati via B4 Relay
2026-11-22 19:31 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228257@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=venkat.yadlapati@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox