From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A757F7D4 for ; Tue, 5 Mar 2024 07:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709625152; cv=none; b=K2GRgcsGetRmJFeeZjFwTgaTMoIoU1YwIaABZdSdJw0w4J5mkBZxMy8/hVoXWN6s7Un6LKWS9boC48vIo4mq7Jy7szsCHvWf4yKNQEem/bqJ+1rkxGss9UbpvxAuul1JacS7v0+P5AtTBBUmDii5Oe4H70Lmo64EDUDqG8e11qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709625152; c=relaxed/simple; bh=+AQlQK0Lza0f5cu21CkeCnxElnTqhZNcxRlem6VN6L0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kl0XLjwlUAoPOVR2K7tknnZ7ogJl229hDleXPfqPPmmdBPn2AoBDPJKTG+U/vbPCnOau+mxYLLm/WwlYj++nta1OLXtklUYHTDpFOtygtAgjH4E9JBA4HDPog5DR/rquURZMnFGD/O/IoTXfVBaqjCfpJIk1Aw/z5hYhR5++ic0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cyyself.name; spf=none smtp.mailfrom=cyyself.name; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=LCDGbDCw; arc=none smtp.client-ip=162.62.57.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cyyself.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=cyyself.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="LCDGbDCw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1709624839; bh=g5kgWxn1NIxh/U33f+1njLKEvQkBSk5gIYUqK8r5evU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=LCDGbDCwYGUQi+o2l4zqRcEZaCrkX297/Y6vTVxmHzBk4eepQgpJx2YPZgJkb+d0T z55wijeuGIrkDXeRIk38CZ9/FufV354Ql58pax6cLzTv+Y7Jaka7yJKN0W8SI13wyt NAe3FZK4vqAzxBNDf38xUfUetxUzxGId+P2i/OFU= Received: from [IPV6:2001:da8:c800:d084:f0c8:5d03:8100:4abe] ([2001:da8:c800:d084:f0c8:5d03:8100:4abe]) by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP id BCFB4E35; Tue, 05 Mar 2024 15:47:15 +0800 X-QQ-mid: xmsmtpt1709624835t312y5jks Message-ID: X-QQ-XMAILINFO: MRMtjO3A6C9Xa8SSBDSIszojUPOQR3Pu/YiSKnZ9CLUlp33j5I4BOid6UBpNni k0FZVOccwXNfc6U3Gk2ep4umWe2WreSNJpgnico/BladWbJulFvtIJ640xgIS6L++jcew4UWTlR3 V2udqtjWFqXUEm9nO4o3JHRxrm1mluMwBFtOY4M5WX7+8f8lKJdebMzqlKAy7X36UnyoTyCvhKN5 33mfbM1t2mzcDPa1IX8cuJDiE9h2pwMBYQJHFyMjXIJTpq2RxmIG1Neq4hjT9Y5L0tMBo5d3aOCx xFYL/rarWRKEZv46xrrJRt1ZGxUxXT5Jses+xQWME63PA8pp7wS9Px6RFi7KzY3YBt3rH7qTwa82 UCV/zNu89FpSV6notQosadR8xoHVIfjjVBoNcyDHdtehGS46YrMmS+xsRqcVpOtASGLJBbquX/2O xDjp64aZmsiaX++BnbZ2jwdFBY6lQmGEysXk+PuvBcMWHdNpA91T5phc6DofwzNz8TAaHxEllH0w B1IaCKoPS0kRkQvXNQuEnWfoX30Yo+wZ4WXFK0/RNi0MrahUmAdDGpzpoGjY0Dai9aPKuxDiZR7w bZ+ZblwIu91JhbF/9yHCjYiiCWDC20A+6DKuVSj/+aKUzRkGJFTyiTX8Nx4KXlW4DCsf1P3eRSNn IZ1GXAimu3gC4vA624z8JqOhJMzOUvefatPu8x5alvcYp2rnl4fklz+Mp4SIRSonX+85Zl/V9n0y N7QEO0tGlzjCy+fu64bi39/zRM4nnzKrUdnr6LoeOO3FQkUJw5YwAEy5+c/YjuCDEDN8rsNgN5EF X5eKadoM9zjR7g2sGtWApTsOVwcYXiwEBZzUcrE0V8TbVgm0JBxO+xa4yxeb0FKUyIOQcMkWJUa6 6cPUPjSOePfkVTLQdM5//+UipMwTU8uVv0mr3y8BQY/yn2Bni+o2SfWIt/4oyOB+jCwGwEzGH7zG rQqUipDJK2veb7DniAdVVtPRM1MTQhkYXalaxZLVKUcV22g8Y+DQ== X-QQ-XMRINFO: Nq+8W0+stu50PRdwbJxPCL0= X-OQ-MSGID: Date: Tue, 5 Mar 2024 15:47:15 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/7] riscv: Kconfig.socs: Allow SOC_CANAAN with MMU for K230 Content-Language: en-US To: Damien Le Moal , linux-riscv@lists.infradead.org Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley References: From: Yangyu Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/5 07:46, Damien Le Moal wrote: > On 3/5/24 06:05, Yangyu Chen wrote: >> Since K230 was released, SOC_CANAAN is no longer only referred to the K210. >> Remove it depends on !MMU will allow building dts for K230 and remove the >> K210 string from the help message. >> >> Signed-off-by: Yangyu Chen >> Reviewed-by: Conor Dooley >> --- >> arch/riscv/Kconfig.socs | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs >> index 623de5f8a208..b4e9b7f75510 100644 >> --- a/arch/riscv/Kconfig.socs >> +++ b/arch/riscv/Kconfig.socs >> @@ -75,13 +75,12 @@ config ARCH_CANAAN >> def_bool SOC_CANAAN >> >> config SOC_CANAAN >> - bool "Canaan Kendryte K210 SoC" >> - depends on !MMU > > This seems wrong to me. The k210 support does require no-mmu. So why remove > this ? It just allows SOC_CANAAN to be selected when MMU=y. With this patch, nommu_k210_defconfig still works. > Does the k230 have MMU support ? If yes, then I do not think these 2 can > fall under the same SOC_CANAAN. > Yes, K230 has MMU, you can see the bootlog from the cover letter and the dts patch [6/7]. Could you provide some reasons why it can fall? I didn't see any differences in .config after this change after executing 'make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- nommu_k210_defconfig'. >> + bool "Canaan Kendryte SoC" >> select CLINT_TIMER if RISCV_M_MODE >> select ARCH_HAS_RESET_CONTROLLER >> select PINCTRL >> select COMMON_CLK >> help >> - This enables support for Canaan Kendryte K210 SoC platform hardware. >> + This enables support for Canaan Kendryte SoC platform hardware. >> >> endmenu # "SoC selection" >