From: Dave Hansen <dave.hansen@intel.com>
To: Ram Pai <linuxram@us.ibm.com>,
shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, akpm@linux-foundation.org,
benh@kernel.crashing.org, paulus@samba.org,
khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org,
bauerman@linux.vnet.ibm.com, ebiederm@xmission.com,
arnd@arndb.de
Subject: Re: [PATCH v12 04/22] selftests/vm: typecast the pkey register
Date: Fri, 16 Mar 2018 14:58:16 -0700 [thread overview]
Message-ID: <00081300-e891-3381-3acd-e3312e54fb58@intel.com> (raw)
In-Reply-To: <1519264541-7621-5-git-send-email-linuxram@us.ibm.com>
On 02/21/2018 05:55 PM, Ram Pai wrote:
> -static inline unsigned int _rdpkey_reg(int line)
> +static inline pkey_reg_t _rdpkey_reg(int line)
> {
> - unsigned int pkey_reg = __rdpkey_reg();
> + pkey_reg_t pkey_reg = __rdpkey_reg();
>
> - dprintf4("rdpkey_reg(line=%d) pkey_reg: %x shadow: %x\n",
> + dprintf4("rdpkey_reg(line=%d) pkey_reg: %016lx shadow: %016lx\n",
> line, pkey_reg, shadow_pkey_reg);
> assert(pkey_reg == shadow_pkey_reg);
Hmm. So we're using %lx for an int? Doesn't the compiler complain
about this?
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-16 21:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1519264541-7621-1-git-send-email-linuxram@us.ibm.com>
[not found] ` <1519264541-7621-3-git-send-email-linuxram@us.ibm.com>
2018-03-16 21:55 ` [PATCH v12 02/22] selftests/vm: rename all references to pkru to a generic name Dave Hansen
[not found] ` <1519264541-7621-5-git-send-email-linuxram@us.ibm.com>
2018-03-16 21:58 ` Dave Hansen [this message]
2018-03-26 19:38 ` [PATCH v12 04/22] selftests/vm: typecast the pkey register Thiago Jung Bauermann
[not found] ` <1519264541-7621-6-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:05 ` [PATCH v12 05/22] selftests/vm: generic function to handle shadow key register Dave Hansen
[not found] ` <1519264541-7621-7-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:06 ` [PATCH v12 06/22] selftests/vm: fix the wrong assert in pkey_disable_set() Dave Hansen
[not found] ` <1519264541-7621-8-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:08 ` [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear() Dave Hansen
2018-03-28 20:47 ` Thiago Jung Bauermann
2018-03-28 20:55 ` Dave Hansen
2018-03-28 23:51 ` Thiago Jung Bauermann
[not found] ` <1519264541-7621-9-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:10 ` [PATCH v12 08/22] selftests/vm: clear the bits in shadow reg when a pkey is freed Dave Hansen
[not found] ` <1519264541-7621-10-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:13 ` [PATCH v12 09/22] selftests/vm: fix alloc_random_pkey() to make it really random Dave Hansen
[not found] ` <1519264541-7621-11-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:15 ` [PATCH v12 10/22] selftests/vm: introduce two arch independent abstraction Dave Hansen
[not found] ` <1519264541-7621-12-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:19 ` [PATCH v12 11/22] selftests/vm: pkey register should match shadow pkey Dave Hansen
[not found] ` <1519264541-7621-13-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:22 ` [PATCH v12 12/22] selftests/vm: generic cleanup Dave Hansen
[not found] ` <1519264541-7621-14-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:23 ` [PATCH v12 13/22] selftests/vm: powerpc implementation for generic abstraction Dave Hansen
[not found] ` <1519264541-7621-15-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:24 ` [PATCH v12 14/22] selftests/vm: clear the bits in shadow reg when a pkey is freed Dave Hansen
[not found] ` <1519264541-7621-16-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:26 ` [PATCH v12 15/22] selftests/vm: powerpc implementation to check support for pkey Dave Hansen
[not found] ` <1519264541-7621-17-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:28 ` [PATCH v12 16/22] selftests/vm: fix an assertion in test_pkey_alloc_exhaust() Dave Hansen
[not found] ` <1519264541-7621-18-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:30 ` [PATCH v12 17/22] selftests/vm: associate key on a mapped page and detect access violation Dave Hansen
[not found] ` <1519264541-7621-19-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:30 ` [PATCH v12 18/22] selftests/vm: associate key on a mapped page and detect write violation Dave Hansen
[not found] ` <1519264541-7621-20-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:31 ` [PATCH v12 19/22] selftests/vm: detect write violation on a mapped access-denied-key page Dave Hansen
[not found] ` <1519264541-7621-21-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:32 ` [PATCH v12 20/22] selftests/vm: testcases must restore pkey-permissions Dave Hansen
[not found] ` <1519264541-7621-22-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:33 ` [PATCH v12 21/22] selftests/vm: sub-page allocator Dave Hansen
[not found] ` <1519264541-7621-23-git-send-email-linuxram@us.ibm.com>
2018-03-16 22:34 ` [PATCH v12 22/22] selftests/vm: Fix deadlock in protection_keys.c Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00081300-e891-3381-3acd-e3312e54fb58@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=bauerman@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=shuahkh@osg.samsung.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).