From: Andrew Lunn <andrew@lunn.ch>
To: Dong Yibo <dong100@mucse.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
corbet@lwn.net, gur.stavi@huawei.com, maddy@linux.ibm.com,
mpe@ellerman.id.au, danishanwar@ti.com, lee@trager.us,
gongfan1@huawei.com, lorenzo@kernel.org, geert+renesas@glider.be,
Parthiban.Veerasooran@microchip.com, lukas.bulwahn@redhat.com,
alexanderduyck@fb.com, richardcochran@gmail.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] net: rnpgbe: Add build support for rnpgbe
Date: Fri, 15 Aug 2025 03:58:46 +0200 [thread overview]
Message-ID: <00e2690c-3b26-46c3-9b27-1c1a73964326@lunn.ch> (raw)
In-Reply-To: <20250814073855.1060601-2-dong100@mucse.com>
> +static void rnpgbe_shutdown(struct pci_dev *pdev)
> +{
> + bool wake;
> +
> + rnpgbe_dev_shutdown(pdev, &wake);
> +
> + if (system_state == SYSTEM_POWER_OFF) {
> + pci_wake_from_d3(pdev, wake);
> + pci_set_power_state(pdev, PCI_D3hot);
> + }
I don't think you need this test of system state until you have added
WoL support.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-08-15 1:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 7:38 [PATCH v4 0/5] Add driver for 1Gbe network chips from MUCSE Dong Yibo
2025-08-14 7:38 ` [PATCH v4 1/5] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-08-15 1:58 ` Andrew Lunn [this message]
2025-08-14 7:38 ` [PATCH v4 2/5] net: rnpgbe: Add n500/n210 chip support Dong Yibo
2025-08-14 12:07 ` MD Danish Anwar
2025-08-14 13:52 ` Yibo Dong
2025-08-15 2:07 ` Andrew Lunn
2025-08-15 2:05 ` Andrew Lunn
2025-08-15 2:38 ` Yibo Dong
2025-08-15 3:56 ` Andrew Lunn
2025-08-15 7:21 ` Yibo Dong
2025-08-15 13:36 ` Andrew Lunn
2025-08-18 1:14 ` Yibo Dong
2025-08-14 7:38 ` [PATCH v4 3/5] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-08-15 2:13 ` Andrew Lunn
2025-08-15 2:43 ` Yibo Dong
2025-08-15 3:59 ` Andrew Lunn
2025-08-15 7:22 ` Yibo Dong
2025-08-15 2:29 ` Andrew Lunn
2025-08-15 3:15 ` Yibo Dong
2025-08-14 7:38 ` [PATCH v4 4/5] net: rnpgbe: Add basic mbx_fw support Dong Yibo
2025-08-14 12:10 ` MD Danish Anwar
2025-08-14 13:54 ` Yibo Dong
2025-08-15 3:27 ` Andrew Lunn
2025-08-15 6:36 ` Yibo Dong
2025-08-15 13:21 ` Andrew Lunn
2025-08-18 2:14 ` Yibo Dong
2025-08-14 7:38 ` [PATCH v4 5/5] net: rnpgbe: Add register_netdev Dong Yibo
2025-08-14 12:14 ` MD Danish Anwar
2025-08-14 13:59 ` Yibo Dong
2025-08-15 2:28 ` Yibo Dong
2025-08-15 3:42 ` Andrew Lunn
2025-08-15 6:44 ` Yibo Dong
2025-08-15 18:06 ` Andrew Lunn
2025-08-18 1:21 ` Yibo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e2690c-3b26-46c3-9b27-1c1a73964326@lunn.ch \
--to=andrew@lunn.ch \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gongfan1@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).