From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9843C43334 for ; Wed, 8 Jun 2022 06:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233182AbiFHGyy (ORCPT ); Wed, 8 Jun 2022 02:54:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354904AbiFHGTy (ORCPT ); Wed, 8 Jun 2022 02:19:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ECD86B42 for ; Tue, 7 Jun 2022 23:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654669171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2qdpgRzMUhsIWQD2m9gzx7YEZ9aS+BKgAe1jCPfxbsI=; b=Nrri5V29gAi0n0GV3m1fTE+oEzQP1i34JY5XNh8Ppx87T1vvRBNBuod/P6xVc6AIN4RYqn jR9gLdbsg3YjeBpT8OQatqDas0CbxhnAvsFKNeXI/QpD5QiA/unsq2JXhqFjfgqfVi9Hyt HXpD02CoSCc4B9bCJRmn/pJPX8naFQs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-319-OQgB-pqwPbe6tDh4ln5aKQ-1; Wed, 08 Jun 2022 02:19:29 -0400 X-MC-Unique: OQgB-pqwPbe6tDh4ln5aKQ-1 Received: by mail-wr1-f71.google.com with SMTP id v4-20020adfebc4000000b002102c69be5eso4416214wrn.13 for ; Tue, 07 Jun 2022 23:19:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=2qdpgRzMUhsIWQD2m9gzx7YEZ9aS+BKgAe1jCPfxbsI=; b=0E40vaZJf/wSfvcwFEUYTYN7ZMn3WuxM7KODNji4HvLIUjwGIB7WqhNTISoG9ZFDQb kCl3CDj1VQmu4uzGlkhfLjkfwIzRWZxHZ2y7Oj/5xWTLU0AdZRAughP5uQURiJCGA6vZ cTw7XNFh0bFwVFJZ1OCgaIOQZ6trg2anrrDM702ul6iCy9fb0aZK1aqE/e34E+9sD0SC imKcwiP4S23awF4K/B7lUYAaoeY0FCYiFDot7C9TB9HSpus5xsyVFjdqBG6fcE9g8HVa px+JqJ7xVwZCBzI/vx/tA3LzQFT/5jeS9FY7b8vX+B0/DZqU0zCFgM0VPnNlifjXnpu+ sOjg== X-Gm-Message-State: AOAM532nEY5n4KRybSrCvhglY2Xwi1THC1WaVCubmD4vwuImLfu4bxRA /vWLOTaGwrX/mXm8ng9sN2lGU5lVX6C8kqQWyh/82Iq46udjvMfnGMgQFhNzX2CDdrJqbV34h9p jI+MDkyr8KkyFK4j8+F8/ X-Received: by 2002:adf:d1c4:0:b0:210:1935:3dd8 with SMTP id b4-20020adfd1c4000000b0021019353dd8mr31593021wrd.229.1654669167905; Tue, 07 Jun 2022 23:19:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkaMUFdFQF32rETtSx3hpO9mEFM8hwy/9yxM+E2FB4DD6LrNRYSSbnwhOPIH9KVPr+yWRkng== X-Received: by 2002:adf:d1c4:0:b0:210:1935:3dd8 with SMTP id b4-20020adfd1c4000000b0021019353dd8mr31592992wrd.229.1654669167726; Tue, 07 Jun 2022 23:19:27 -0700 (PDT) Received: from [192.168.0.3] (ip-109-42-114-66.web.vodafone.de. [109.42.114.66]) by smtp.gmail.com with ESMTPSA id m125-20020a1ca383000000b0039c5b4ab1b0sm3545849wme.48.2022.06.07.23.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 23:19:27 -0700 (PDT) Message-ID: <025699e6-b870-2648-d4a4-ffbc5fff22e8@redhat.com> Date: Wed, 8 Jun 2022 08:19:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Matthew Rosato , linux-s390@vger.kernel.org Cc: alex.williamson@redhat.com, cohuck@redhat.com, schnelle@linux.ibm.com, farman@linux.ibm.com, pmorel@linux.ibm.com, borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com, imbrenda@linux.ibm.com, vneethv@linux.ibm.com, oberpar@linux.ibm.com, freude@linux.ibm.com, pasic@linux.ibm.com, pbonzini@redhat.com, corbet@lwn.net, jgg@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20220606203325.110625-1-mjrosato@linux.ibm.com> <20220606203325.110625-11-mjrosato@linux.ibm.com> From: Thomas Huth Subject: Re: [PATCH v9 10/21] vfio/pci: introduce CONFIG_VFIO_PCI_ZDEV_KVM In-Reply-To: <20220606203325.110625-11-mjrosato@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 06/06/2022 22.33, Matthew Rosato wrote: > The current contents of vfio-pci-zdev are today only useful in a KVM > environment; let's tie everything currently under vfio-pci-zdev to > this Kconfig statement and require KVM in this case, reducing complexity > (e.g. symbol lookups). > > Signed-off-by: Matthew Rosato > --- > drivers/vfio/pci/Kconfig | 11 +++++++++++ > drivers/vfio/pci/Makefile | 2 +- > include/linux/vfio_pci_core.h | 2 +- > 3 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig > index 4da1914425e1..f9d0c908e738 100644 > --- a/drivers/vfio/pci/Kconfig > +++ b/drivers/vfio/pci/Kconfig > @@ -44,6 +44,17 @@ config VFIO_PCI_IGD > To enable Intel IGD assignment through vfio-pci, say Y. > endif > > +config VFIO_PCI_ZDEV_KVM > + bool "VFIO PCI extensions for s390x KVM passthrough" > + depends on S390 && KVM > + default y > + help > + Support s390x-specific extensions to enable support for enhancements > + to KVM passthrough capabilities, such as interpretive execution of > + zPCI instructions. > + > + To enable s390x KVM vfio-pci extensions, say Y. Is it still possible to disable CONFIG_VFIO_PCI_ZDEV_KVM ? Looking at the later patches (e.g. 20/21 where you call kvm_s390_pci_zpci_op() from kvm-s390.c), it rather seems to me that it currently cannot be disabled independently (as long as KVM is enabled). So if you want to make this selectable by the user, I think you have to put some more #ifdefs in the following patches. But if this was not meant to be selectable by the user, I think it should not get a help text and rather be selected by the KVM switch in arch/s390/kvm/Kconfig instead of having a "default y". Thomas