From: Markus Elfring <Markus.Elfring@web.de>
To: Babu Moger <babu.moger@amd.com>,
x86@kernel.org, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Reinette Chatre <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, "Breno Leitao" <leitao@debian.org>,
"Daniel Sneddon" <daniel.sneddon@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"James Morse" <james.morse@arm.com>,
"Jim Mattson" <jmattson@google.com>,
"Jithu Joseph" <jithu.joseph@intel.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Julia Lawall" <julia.lawall@inria.fr>,
"Kai Huang" <kai.huang@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Kim Phillips" <kim.phillips@amd.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Peter Newman" <peternewman@google.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Rick Edgecombe" <rick.p.edgecombe@intel.com>,
"Sandipan Das" <sandipan.das@amd.com>,
"Sean Christopherson" <seanjc@google.com>,
"Stephane Eranian" <eranian@google.com>,
"Tejun Heo" <tj@kernel.org>, "Yan-Jie Wang" <yanjiewtw@gmail.com>
Subject: Re: [PATCH v4 17/19] x86/resctrl: Introduce the interface switch between ABMC and mbm_legacy
Date: Fri, 21 Jun 2024 16:43:15 +0200 [thread overview]
Message-ID: <038fdd79-b465-4fa7-aac1-1526dcb2d87f@web.de> (raw)
In-Reply-To: <0148e3317b0de3b5d1eaa58af37a2910783a69c9.1716552602.git.babu.moger@amd.com>
…
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
…
> +static ssize_t rdtgroup_mbm_assign_write(struct kernfs_open_file *of,
> + char *buf, size_t nbytes,
> + loff_t off)
> +{
…
> + cpus_read_lock();
> + mutex_lock(&rdtgroup_mutex);
> +
> + rdt_last_cmd_clear();
…
> + mutex_unlock(&rdtgroup_mutex);
> + cpus_read_unlock();
> +
> + return ret ?: nbytes;
> +}
…
Would you become interested to apply statements like the following?
* guard(cpus_read_lock)();
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L133
* guard(mutex)(&rdtgroup_mutex);
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-21 14:44 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 12:23 [PATCH v4 00/19] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2024-05-24 12:23 ` [PATCH v4 01/19] x86/resctrl: Add support for " Babu Moger
2024-06-14 0:54 ` Reinette Chatre
2024-06-18 21:02 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 02/19] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2024-05-24 12:23 ` [PATCH v4 03/19] x86/resctrl: Consolidate monitoring related data from rdt_resource Babu Moger
2024-06-14 0:55 ` Reinette Chatre
2024-06-18 21:02 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 04/19] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2024-06-14 0:56 ` Reinette Chatre
2024-06-18 21:03 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 05/19] x86/resctrl: Introduce resctrl_file_fflags_init to initialize fflags Babu Moger
2024-06-14 0:57 ` Reinette Chatre
2024-06-18 21:03 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 06/19] x86/resctrl: Introduce interface to display number of ABMC counters Babu Moger
2024-06-14 0:57 ` Reinette Chatre
2024-06-18 21:04 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 07/19] x86/resctrl: Add support to enable/disable ABMC feature Babu Moger
2024-06-14 0:59 ` Reinette Chatre
2024-06-19 15:37 ` Moger, Babu
2024-06-20 22:02 ` Reinette Chatre
2024-06-21 15:44 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 08/19] x86/resctrl: Introduce the interface to display monitor mode Babu Moger
2024-06-14 1:40 ` Reinette Chatre
2024-06-19 16:25 ` Moger, Babu
2024-06-20 22:05 ` Reinette Chatre
2024-06-21 15:47 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 09/19] x86/resctrl: Initialize ABMC counters bitmap Babu Moger
2024-06-14 1:42 ` Reinette Chatre
2024-06-19 17:03 ` Moger, Babu
2024-06-20 22:20 ` Reinette Chatre
2024-06-21 16:01 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 10/19] x86/resctrl: Introduce ABMC state for the monitor group Babu Moger
2024-05-24 12:23 ` [PATCH v4 11/19] x86/resctrl: Introduce mbm_total_cfg and mbm_local_cfg Babu Moger
2024-06-14 1:43 ` Reinette Chatre
2024-06-19 18:46 ` Moger, Babu
2024-06-27 18:51 ` Moger, Babu
2024-06-27 20:56 ` Reinette Chatre
2024-06-27 21:26 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 12/19] x86/resctrl: Remove MSR reading of event configuration value Babu Moger
2024-05-24 12:23 ` [PATCH v4 13/19] x86/resctrl: Add data structures for ABMC assignment Babu Moger
2024-06-14 1:44 ` Reinette Chatre
2024-06-19 20:10 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 14/19] x86/resctrl: Add the interface to assign ABMC counter Babu Moger
2024-06-14 1:48 ` Reinette Chatre
2024-06-19 22:38 ` Moger, Babu
2024-06-20 22:50 ` Reinette Chatre
2024-06-21 16:07 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 15/19] x86/resctrl: Add the interface to unassign " Babu Moger
2024-06-14 1:49 ` Reinette Chatre
2024-06-20 13:48 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 16/19] x86/resctrl: Enable ABMC by default on resctrl mount Babu Moger
2024-06-14 1:50 ` Reinette Chatre
2024-06-20 14:46 ` Moger, Babu
2024-06-20 22:49 ` Reinette Chatre
2024-06-21 16:29 ` Moger, Babu
2024-05-24 12:23 ` [PATCH v4 17/19] x86/resctrl: Introduce the interface switch between ABMC and mbm_legacy Babu Moger
2024-06-14 1:51 ` Reinette Chatre
2024-06-20 14:53 ` Moger, Babu
2024-06-21 14:43 ` Markus Elfring [this message]
2024-05-24 12:23 ` [PATCH v4 18/19] x86/resctrl: Introduce interface to list monitor states of all the groups Babu Moger
2024-05-24 12:23 ` [PATCH v4 19/19] x86/resctrl: Introduce interface to modify assignment states of " Babu Moger
2024-06-14 0:54 ` [PATCH v4 00/19] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Reinette Chatre
2024-06-18 21:02 ` Moger, Babu
2024-06-20 22:49 ` Reinette Chatre
2024-06-21 16:41 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038fdd79-b465-4fa7-aac1-1526dcb2d87f@web.de \
--to=markus.elfring@web.de \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=jithu.joseph@intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).