linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Thaler <dthaler1968@googlemail.com>
To: "'Eslam Khafagy'" <eslam.medhat1993@gmail.com>,
	<void@manifault.com>, <ast@kernel.org>
Cc: <linux-doc@vger.kernel.org>, <skhan@linuxfoundation.org>,
	<bpf@vger.kernel.org>
Subject: RE: [PATCH bpf-next] Documentation: Fix spelling mistake.
Date: Fri, 6 Jun 2025 08:17:41 -0700	[thread overview]
Message-ID: <04a101dbd6f6$2635cac0$72a16040$@gmail.com> (raw)
In-Reply-To: <20250606100511.368450-1-eslam.medhat1993@gmail.com>



> -----Original Message-----
> From: Eslam Khafagy <eslam.medhat1993@gmail.com>
> Sent: Friday, June 6, 2025 3:05 AM
> To: void@manifault.com; ast@kernel.org
> Cc: linux-doc@vger.kernel.org; skhan@linuxfoundation.org;
bpf@vger.kernel.org;
> Eslam Khafagy <eslam.medhat1993@gmail.com>
> Subject: [PATCH bpf-next] Documentation: Fix spelling mistake.
> 
> Fix typo "desination => destination"
> in file
> Documentation/bpf/standardization/instruction-set.rst
> 
> Signed-off-by: Eslam Khafagy <eslam.medhat1993@gmail.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index fbe975585236..ac950a5bb6ad 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -350,9 +350,9 @@ Underflow and overflow are allowed during arithmetic
> operations, meaning  the 64-bit or 32-bit value will wrap. If BPF program
execution
> would  result in division by zero, the destination register is instead set
to zero.
>  Otherwise, for ``ALU64``, if execution would result in ``LLONG_MIN``
-dividing -1,
> the desination register is instead set to ``LLONG_MIN``. For
> +dividing -1, the destination register is instead set to ``LLONG_MIN``.
> +For
>  ``ALU``, if execution would result in ``INT_MIN`` dividing -1, the
-desination register
> is instead set to ``INT_MIN``.
> +destination register is instead set to ``INT_MIN``.
> 
>  If execution would result in modulo by zero, for ``ALU64`` the value of
the
> destination register is unchanged whereas for ``ALU`` the upper
> --
> 2.43.0

For just the spelling correction:
Acked-by: Dave Thaler <dthaler1968@gmail.com>

However the phrase "dividing -1" is one I find confusing.  E.g.,
"INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse.
Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

Dave


  reply	other threads:[~2025-06-06 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 10:05 [PATCH bpf-next] Documentation: Fix spelling mistake Eslam Khafagy
2025-06-06 15:17 ` Dave Thaler [this message]
2025-06-06 17:37   ` David Vernet
2025-06-07 22:25   ` Eslam Khafagy
2025-06-07  3:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='04a101dbd6f6$2635cac0$72a16040$@gmail.com' \
    --to=dthaler1968@googlemail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eslam.medhat1993@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).