Re: [PATCH] cpufreq: Documentation: fix sampling_down_factor documentation range

[Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>]

On 5/15/2026 5:49 PM, Pengjie Zhang wrote:
> The ondemand governor implementation accepts sampling_down_factor values
> from 1 to 100000 via MAX_SAMPLING_DOWN_FACTOR, but the documentation in
> admin-guide/pm/cpufreq.rst still says the valid range is 1 to 100.
> 
> Update the documentation to match the actual code.
> 
> Fixes: 2a0e49279850 ("cpufreq: User/admin documentation update and consolidation")


Thanks Pengjie,

Yes, commit 3f78a9f7fcee introduced MAX_SAMPLING_DOWN_FACTOR (100000),
and commit 2a0e49279850 updated the documentation later, so the Fixes
tag is correct.

Small nit: "documentation range" feels a bit redundant; just "range"
might be enough.

Looks good to me.

Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>


> Signed-off-by: Pengjie Zhang <zhangpengjie2@huawei.com>
> ---
>   Documentation/admin-guide/pm/cpufreq.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/pm/cpufreq.rst b/Documentation/admin-guide/pm/cpufreq.rst
> index dbe6d23a5d67..fdca59c955dc 100644
> --- a/Documentation/admin-guide/pm/cpufreq.rst
> +++ b/Documentation/admin-guide/pm/cpufreq.rst
> @@ -516,7 +516,7 @@ This governor exposes the following tunables:
>   	of those tasks above 0 and set this attribute to 1.
>   
>   ``sampling_down_factor``
> -	Temporary multiplier, between 1 (default) and 100 inclusive, to apply to
> +	Temporary multiplier, between 1 (default) and 100000 inclusive, to apply to
>   	the ``sampling_rate`` value if the CPU load goes above ``up_threshold``.
>   
>   	This causes the next execution of the governor's worker routine (after


-- 
Thx and BRs,
Zhongqiu Han