From: Randy Dunlap <rdunlap@infradead.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>,
Henk Vergonet <Henk.Vergonet@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: yealink.rst: Fix typos and wording
Date: Sun, 6 Sep 2026 09:33:10 -0700 [thread overview]
Message-ID: <06cc9fc4-28ba-4076-917e-5ac30336806a@infradead.org> (raw)
In-Reply-To: <20260906095502.1116994-2-manuelebnerli@mailbox.org>
Hi,
On 9/6/26 2:55 AM, Manuel Ebner wrote:
> Improve readability.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> CC: Randy Dunlap <rdunlap@infradead.org>
> ---
> [v3]
> fix wording
> droped white-space fixes
>
> [v2]
> add ']' instead of remove '[' as randy suggested
> fix a couple more issues in the file
>
> [v1]
> https://lore.kernel.org/all/20260904121026.759218-3-manuelebnerli@mailbox.org/
> ---
> Documentation/input/devices/yealink.rst | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/input/devices/yealink.rst b/Documentation/input/devices/yealink.rst
> index bb5a1aafe..de1460b6b 100644
> --- a/Documentation/input/devices/yealink.rst
> +++ b/Documentation/input/devices/yealink.rst
> @@ -120,9 +120,10 @@ Reading /sys/../lineX will return the format string with its current value.
> Writing to /sys/../lineX will set the corresponding LCD line.
>
> - Excess characters are ignored.
> - - If less characters are written than allowed, the remaining digits are
> + - If fewer characters than allowed are written, the remaining digits are
> unchanged.
> - - The tab '\t'and '\n' char does not overwrite the original content.
> + - The tab '\t' and newline '\n' characters do not overwrite the original
> + content.
In looking at the produced html, the backslashes above are missing.
This fixes it, although I don't know if it's the best or only fix:
- The tab '\\t' and newline '\\n' characters do not overwrite the original
content.
With that fixed:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> - Writing a space to an icon will always hide its content.
>
> Example::
> @@ -205,7 +206,7 @@ Troubleshooting
> :Q: Module yealink compiled and installed without any problem but phone
> is not initialized and does not react to any actions.
> :A: If you see something like:
> - hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone
> + hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone]
> in dmesg, it means that the hid driver has grabbed the device first. Try to
> load module yealink before any other usb hid driver. Please see the
> instructions provided by your distribution on module configuration.
--
~Randy
next prev parent reply other threads:[~2026-09-06 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 9:55 [PATCH v3] Input: yealink.rst: Fix typos and wording Manuel Ebner
2026-09-06 16:33 ` Randy Dunlap [this message]
2026-09-07 0:49 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cc9fc4-28ba-4076-917e-5ac30336806a@infradead.org \
--to=rdunlap@infradead.org \
--cc=Henk.Vergonet@gmail.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuelebnerli@mailbox.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox