From: Reinette Chatre <reinette.chatre@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
<tglx@linutronix.de>, <mingo@redhat.com>, <fenghua.yu@intel.com>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<paulmck@kernel.org>, <akpm@linux-foundation.org>,
<quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
<peterz@infradead.org>, <jpoimboe@kernel.org>,
<pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
<pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
<daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
<tony.luck@intel.com>, <james.morse@arm.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bagasdotme@gmail.com>, <eranian@google.com>,
<christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
<adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
<peternewman@google.com>
Subject: Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside rdt_enable_ctx()
Date: Mon, 9 Oct 2023 13:10:24 -0700 [thread overview]
Message-ID: <07e8d51d-6e40-44ba-8223-9f2af36a8bb1@intel.com> (raw)
In-Reply-To: <20231009192340.GEZSRTPE9b9hOtu0JJ@fat_crate.local>
Hi Boris,
On 10/9/2023 12:23 PM, Borislav Petkov wrote:
> On Mon, Oct 09, 2023 at 10:59:27AM -0700, Reinette Chatre wrote:
>> Is it the fourth paragraph (mentioning cdp_disable_all()) that is annoying? I
>> can see that it is redundant. Would it be more palatable if the fourth paragraph
>> is just dropped?
>
> Yes, basically you don't want to explain what a patch does as that
> should be obvious from the diff. Rather, it should talk about why
> a change is being done. Sure, sometimes, you need to talk about the
> change in case you want to highlight certain aspects of why the code is
> being changed in the first place but explaining in text what is already
> visible in the diff is not very useful.
>
> I always give the example about git archeology here: put enough info in
> the commit message so that any future reader of it can understand why
> the change was done. The "what" of a patch doesn't belong to that text.
>
> I hope that makes more sense.
>
This is clear. Thank you very much. (I am still working on getting it right
in practice though.)
Reinette
next prev parent reply other threads:[~2023-10-09 20:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 23:54 [PATCH v11 00/10] x86/resctrl: Miscellaneous resctrl features Babu Moger
2023-10-03 23:54 ` [PATCH v11 01/10] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-10-03 23:54 ` [PATCH v11 02/10] x86/resctrl: Simplify rftype flag definitions Babu Moger
2023-10-03 23:54 ` [PATCH v11 03/10] x86/resctrl: Rename rftype flags for consistency Babu Moger
2023-10-09 17:19 ` Borislav Petkov
2023-10-09 17:48 ` Reinette Chatre
2023-10-09 17:53 ` Borislav Petkov
2023-10-09 19:22 ` Moger, Babu
2023-10-09 19:24 ` Moger, Babu
2023-10-03 23:54 ` [PATCH v11 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy Babu Moger
2023-10-09 17:22 ` Borislav Petkov
2023-10-09 19:39 ` Moger, Babu
2023-10-09 19:51 ` Borislav Petkov
2023-10-09 20:36 ` Moger, Babu
2023-10-03 23:54 ` [PATCH v11 05/10] x86/resctrl: Unwind the errors inside rdt_enable_ctx() Babu Moger
2023-10-09 17:25 ` Borislav Petkov
2023-10-09 17:40 ` Fenghua Yu
2023-10-09 19:50 ` Moger, Babu
2023-10-09 17:59 ` Reinette Chatre
2023-10-09 19:23 ` Borislav Petkov
2023-10-09 19:58 ` Moger, Babu
2023-10-09 20:10 ` Reinette Chatre [this message]
2023-10-03 23:54 ` [PATCH v11 06/10] x86/resctrl: Move default group file creation to mount Babu Moger
2023-10-03 23:54 ` [PATCH v11 07/10] x86/resctrl: Introduce "-o debug" mount option Babu Moger
2023-10-03 23:54 ` [PATCH v11 08/10] x86/resctrl: Display CLOSID for resource group Babu Moger
2023-10-03 23:54 ` [PATCH v11 09/10] x86/resctrl: Add support for the files for MON groups only Babu Moger
2023-10-06 17:53 ` Reinette Chatre
2023-10-06 20:49 ` Moger, Babu
2023-10-06 21:01 ` Reinette Chatre
2023-10-09 18:00 ` Borislav Petkov
2023-10-09 22:08 ` Moger, Babu
2023-10-03 23:54 ` [PATCH v11 10/10] x86/resctrl: Display RMID of resource group Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e8d51d-6e40-44ba-8223-9f2af36a8bb1@intel.com \
--to=reinette.chatre@intel.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@amd.com \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox