From: Alex Hung <alex.hung@amd.com>
To: "Albert Esteve" <aesteve@redhat.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH 0/3] drm/amd/display: use kunit/visibility.h for test helpers
Date: Fri, 11 Sep 2026 14:50:55 -0600 [thread overview]
Message-ID: <0819d227-083e-4ce1-b376-81e5941404f2@amd.com> (raw)
In-Reply-To: <20260907-visibility-unification-v1-0-6a962e5b3351@redhat.com>
Looks good to me, and I will forward this to next week's test and update
the results.
On 9/7/26 07:28, Albert Esteve wrote:
> [Some people who received this message don't often get email from aesteve@redhat.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> amdgpu_dm grew its own STATIC_IFN_KUNIT / EXPORT_IF_KUNIT /
> INLINE_IFN_KUNIT macros instead of using kunit/visibility.h. This
> series switches the KUnit helpers over to the common API.
>
> VISIBLE_IF_KUNIT is gated on CONFIG_KUNIT rather than
> CONFIG_DRM_AMD_DC_KUNIT_TEST, so the helpers are non-static whenever
> KUnit is enabled. EXPORT_SYMBOL_IF_KUNIT places the symbols in the
> EXPORTED_FOR_KUNIT_TESTING namespace; the AMD DC test files import
> that namespace with MODULE_IMPORT_NS().
>
> INLINE_IFN_KUNIT is dropped rather than generalized. It was only used
> on amdgpu_dm_fixpt_from_s3132(), inverted the original static inline,
> and is unnecessary for tests in another translation unit.
>
> Tested with:
> ./tools/testing/kunit/kunit.py run --arch=x86_64 \
> --kunitconfig=drivers/gpu/drm/amd/display/amdgpu_dm/tests
>
> (CONFIG_GCOV omitted; it is not available on x86_64.)
>
> Suggested-by: Maxime Ripard <mripard@kernel.org>
>
> Signed-off-by: Albert Esteve <aesteve@redhat.com>
> ---
> Albert Esteve (3):
> drm/amd/display: replace STATIC_IFN_KUNIT with VISIBLE_IF_KUNIT
> drm/amd/display: replace EXPORT_IF_KUNIT with EXPORT_SYMBOL_IF_KUNIT
> drm/amd/display: drop INLINE_IFN_KUNIT
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 79 ++++-----
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_audio.c | 26 +--
> .../amd/display/amdgpu_dm/amdgpu_dm_backlight.c | 74 ++++----
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 133 +++++++--------
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 12 +-
> .../amd/display/amdgpu_dm/amdgpu_dm_connector.c | 190 ++++++++++-----------
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 38 ++---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 52 +++---
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_cursor.c | 10 +-
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_dmub.c | 30 ++--
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_freesync.c | 10 +-
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 105 ++++++------
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 140 +++++++--------
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 146 ++++++++--------
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 40 ++---
> .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 60 +++----
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 104 +++++------
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 116 ++++++-------
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 22 +--
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_quirks.c | 4 +-
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 9 +-
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 10 +-
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +-
> .../display/amdgpu_dm/tests/amdgpu_dm_audio_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_backlight_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_color_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_colorop_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_connector_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_crc_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_crtc_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_cursor_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_dmub_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_freesync_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_hdcp_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_helpers_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_irq_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_ism_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_kunit_helpers.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_plane_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_pp_smu_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_psr_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_quirks_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_replay_test.c | 1 +
> .../amdgpu_dm/tests/amdgpu_dm_services_test.c | 1 +
> .../amd/display/amdgpu_dm/tests/amdgpu_dm_test.c | 1 +
> .../display/amdgpu_dm/tests/amdgpu_dm_wb_test.c | 1 +
> drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 6 +-
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dm_helpers.h | 13 +-
> tools/lib/python/kdoc/xforms_lists.py | 3 +-
> 51 files changed, 748 insertions(+), 728 deletions(-)
> ---
> base-commit: bc35965f6940a9bf834d54187b6088b8eb09206d
> change-id: 20260907-visibility-unification-fd358c580447
>
> Best regards,
> --
> Albert Esteve <aesteve@redhat.com>
prev parent reply other threads:[~2026-09-11 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 13:28 [PATCH 0/3] drm/amd/display: use kunit/visibility.h for test helpers Albert Esteve
2026-09-07 13:28 ` [PATCH 1/3] drm/amd/display: replace STATIC_IFN_KUNIT with VISIBLE_IF_KUNIT Albert Esteve
2026-09-07 13:28 ` [PATCH 2/3] drm/amd/display: replace EXPORT_IF_KUNIT with EXPORT_SYMBOL_IF_KUNIT Albert Esteve
2026-09-07 13:28 ` [PATCH 3/3] drm/amd/display: drop INLINE_IFN_KUNIT Albert Esteve
2026-09-07 15:39 ` Jani Nikula
2026-09-07 15:24 ` [PATCH 0/3] drm/amd/display: use kunit/visibility.h for test helpers Maxime Ripard
2026-09-11 20:50 ` Alex Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0819d227-083e-4ce1-b376-81e5941404f2@amd.com \
--to=alex.hung@amd.com \
--cc=aesteve@redhat.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=rdunlap@infradead.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=skhan@linuxfoundation.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox