From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id EF5A07D099 for ; Wed, 6 Mar 2019 22:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbfCFWNi (ORCPT ); Wed, 6 Mar 2019 17:13:38 -0500 Received: from mga07.intel.com ([134.134.136.100]:13420 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbfCFWNh (ORCPT ); Wed, 6 Mar 2019 17:13:37 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 14:13:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,449,1544515200"; d="scan'208";a="149937658" Received: from skuppusw-desk.jf.intel.com ([10.54.74.33]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2019 14:13:35 -0800 From: sathyanarayanan.kuppuswamy@linux.intel.com To: bhelgaas@google.com, corbet@lwn.net Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Kuppuswamy Sathyanarayanan , Ashok Raj , Keith Busch Subject: [PATCH v1 4/5] PCI/ATS: For PF/VF skip ATS initalization if spec check failed Date: Wed, 6 Mar 2019 14:11:17 -0800 Message-Id: <0898a9bd92cfcf2ab07e5dd5ba59dc181b88edec.1551909341.git.sathyanarayanan.kuppuswamy@linux.intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org From: Kuppuswamy Sathyanarayanan Don't initialize ATS for VF/PF devices if the ATS Capability implementaion is not aligned with PCIe spec r4.0 sec 9.3.7.8. Cc: Ashok Raj Cc: Keith Busch Suggested-by: Ashok Raj Reviewed-by: Keith Busch Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/ats.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 28bbf7dad425..11299d93a59a 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -23,6 +23,12 @@ void pci_ats_init(struct pci_dev *dev) if (pci_ats_disabled()) return; + /* If ATS Cap is invalid then return */ + if (dev->is_virtfn || dev->is_physfn) { + if (dev->invalid_cap & PCI_IOV_INVALID_ATS) + return; + } + pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ATS); if (!pos) return; -- 2.20.1