From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC07BE4D for ; Tue, 14 Nov 2023 09:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1A0D115; Tue, 14 Nov 2023 01:48:13 -0800 (PST) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-9dd6dc9c00cso810868966b.3; Tue, 14 Nov 2023 01:48:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699955292; x=1700560092; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xmgsoxyNFNBJw4J08KM/o4qvUbkmavsgJRhDbBneMmY=; b=fxabq41pf8u6xzQ2s4HZRBK4T2rUdoiqzDdSvZlvBHNLRo3CpGZO66LnvvRkdrduy4 IcQVjFLhyvXvqECkaTjgk7PCq/KEHz41t1JGn9VJVHcRQ/sFIwOjPdsN6UpVc4NNFBjX SWOwkCd73EyEvo29Pow9zEze7C+9+DcD6N+4PxhxZJ43r4Z2tK3H74ZpAB5hkdmWq2cB FVdgeemNVj5ZEd5Au37SBsZXhMbDjGxMAHaw/BgAffdbW5QI7YE4SMMZ69ZmgdtYF3bB ZGgX7bEDKr4TxzKaxmFKeQ9LYZ1fVuAyc0ZR916vpBIOZTZxB++pdlVeOBq0uXXLaze6 xzSw== X-Gm-Message-State: AOJu0YwjmrNWEmxyb3XGT7G1FIqla7NOx/cnP9ZyBQa6ppRusxxHPB95 e6JFiu7ME12XvGOPO5deuNo= X-Google-Smtp-Source: AGHT+IE630q16P809pZHCB8dZm7V0xHgAE4X3XhtoUQIgynu6nai7tw3ePJnYlFHUSjl39B/R2M/8g== X-Received: by 2002:a17:907:6d11:b0:9c5:cfa3:d04d with SMTP id sa17-20020a1709076d1100b009c5cfa3d04dmr8556337ejc.52.1699955291947; Tue, 14 Nov 2023 01:48:11 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id rp21-20020a170906d97500b009e6af2efd77sm5225001ejb.45.2023.11.14.01.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 01:48:11 -0800 (PST) Message-ID: <08ce16bc-e4e9-4cad-b724-ea009d9bcbcb@kernel.org> Date: Tue, 14 Nov 2023 10:48:10 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] serial: uartlite: Use dynamic allocation for major number when uart ports > 4 Content-Language: en-US To: Manikanta Guntupalli , git@amd.com, michal.simek@amd.com, jacmet@sunsite.dk, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, christophe.leroy@csgroup.eu, rdunlap@infradead.org, airlied@redhat.com, ogabbay@kernel.org, linux-doc@vger.kernel.org Cc: radhey.shyam.pandey@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com References: <20231114093303.2718141-1-manikanta.guntupalli@amd.com> <20231114093303.2718141-3-manikanta.guntupalli@amd.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20231114093303.2718141-3-manikanta.guntupalli@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14. 11. 23, 10:33, Manikanta Guntupalli wrote: > Device number 204 has a range of minors on major number. > uart_register_driver is failing due to lack of minor numbers > when more number of uart ports used. So, to avoid minor number > limitation on 204 major number use dynamic major allocation > when more than 4 uart ports used otherwise use static major > allocation. > > https://docs.kernel.org/arch/arm/sa1100/serial_uart.html > > Signed-off-by: Manikanta Guntupalli > --- > Changes for V2: > Update logic to use either static or dynamic major allocation. > Update commit description. > Update description of SERIAL_UARTLITE_NR_UARTS in Kconfig. > --- > drivers/tty/serial/Kconfig | 2 ++ > drivers/tty/serial/uartlite.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 732c893c8d16..368c63066a86 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -532,6 +532,8 @@ config SERIAL_UARTLITE_NR_UARTS > help > Set this to the number of uartlites in your system, or the number > you think you might implement. > + If maximum number of uartlite serial ports more than 4, A verb is missing. The same in patch 1/2. > then driver uses > + dynamic allocation instead of static allocation for major number. > > config SERIAL_SUNCORE > bool > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c > index 404c14acafa5..517f1f34143d 100644 > --- a/drivers/tty/serial/uartlite.c > +++ b/drivers/tty/serial/uartlite.c > @@ -24,8 +24,13 @@ > #include > > #define ULITE_NAME "ttyUL" > +#if (CONFIG_SERIAL_UARTLITE_NR_UARTS > 4) The parentheses are unneeded, right? > +#define ULITE_MAJOR 0 /* use dynamic node allocation */ > +#define ULITE_MINOR 0 > +#else > #define ULITE_MAJOR 204 > #define ULITE_MINOR 187 > +#endif > #define ULITE_NR_UARTS CONFIG_SERIAL_UARTLITE_NR_UARTS > > /* --------------------------------------------------------------------- -- js suse labs