From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 654E57DD31 for ; Mon, 23 Apr 2018 17:41:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbeDWRlA (ORCPT ); Mon, 23 Apr 2018 13:41:00 -0400 Received: from mga02.intel.com ([134.134.136.20]:26648 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932166AbeDWRkz (ORCPT ); Mon, 23 Apr 2018 13:40:55 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 10:40:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,319,1520924400"; d="scan'208";a="53015049" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.147]) ([10.7.153.147]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2018 10:40:54 -0700 Subject: Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core To: Greg KH Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-4-jae.hyun.yoo@linux.intel.com> <20180423105224.GA1444@kroah.com> From: Jae Hyun Yoo Message-ID: <09b1a8af-4d47-0714-8f68-d7fe35cc7a72@linux.intel.com> Date: Mon, 23 Apr 2018 10:40:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180423105224.GA1444@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 4/23/2018 3:52 AM, Greg KH wrote: > On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote: >> +static void peci_adapter_dev_release(struct device *dev) >> +{ >> + /* do nothing */ >> +} > > As per the in-kernel documentation, I am now allowed to make fun of you. > > You are trying to "out smart" the kernel by getting rid of a warning > message that was explicitly put there for you to do something. To think > that by just providing an "empty" function you are somehow fulfilling > the API requirement is quite bold, don't you think? > > This has to be fixed. I didn't put that warning in there for no good > reason. Please go read the documentation again... > > greg k-h > Hi Greg, Thanks a lot for your review. I think, it should contain actual device resource release code which is being done by peci_del_adapter(), or a coupling logic should be added between peci_adapter_dev_release() and peci_del_adapter(). As you suggested, I'll check it again after reading documentation and understanding core.c code more deeply. Jae -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html