From: "Maxime Ripard" <mripard@kernel.org>
To: davidgow@google.com
Cc: kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-sound@vger.kernel.org,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kees Cook" <keescook@chromium.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rae Moar" <rmoar@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>
Subject: Re: [PATCH v2 1/4] kunit: Add APIs for managing devices
Date: Wed, 13 Dec 2023 15:03:02 +0000 [thread overview]
Message-ID: <09db7e8dadfa5d73bdcbf2f6c6af9fbd@kernel.org> (raw)
In-Reply-To: <20231208-kunit_bus-v2-1-e95905d9b325@google.com>
On Fri, 8 Dec 2023 18:09:29 +0800, davidgow@google.com wrote:
> Tests for drivers often require a struct device to pass to other
> functions. While it's possible to create these with
> root_device_register(), or to use something like a platform device, this
> is both a misuse of those APIs, and can be difficult to clean up after,
> for example, a failed assertion.
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-12-13 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 10:09 [PATCH v2 0/4] kunit: Add helpers for creating test-managed devices davidgow
2023-12-08 10:09 ` [PATCH v2 1/4] kunit: Add APIs for managing devices davidgow
2023-12-13 15:03 ` Maxime Ripard [this message]
2023-12-08 10:09 ` [PATCH v2 2/4] fortify: test: Use kunit_device davidgow
2023-12-08 10:09 ` [PATCH v2 3/4] overflow: Replace fake root_device with kunit_device davidgow
2023-12-08 10:09 ` [PATCH v2 4/4] ASoC: topology: Replace fake root_device with kunit_device in tests davidgow
2023-12-13 15:04 ` [PATCH v2 0/4] kunit: Add helpers for creating test-managed devices Maxime Ripard
2023-12-14 8:51 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09db7e8dadfa5d73bdcbf2f6c6af9fbd@kernel.org \
--to=mripard@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=perex@perex.cz \
--cc=rmoar@google.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).