From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0FA355F2A for ; Tue, 26 May 2026 09:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786520; cv=none; b=dBZMVdqDKujE1kQTBQKk2unvRhogHDVfQVZX7++450+AexT9vUY/eKjRpXNwjr26Br6HL+zuThAiTIXy+JOYhbz5jIAkmScdxinssBCpC+SXw0c7FEd4mqAycEghFh4ZBZOME0vsoBlHeGBmnKhInoTV/kHYPh+4fi6ZEq0ng0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786520; c=relaxed/simple; bh=enoBKgdeU4EzY6CsBeR6mlMpvZtWAaQjpP1scNpcCTE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GNB86LBI9abNIX4IQQ8ljC+LD5AnPLd2OEHS8TrjRDKS0hG6XI+rNj7cSVn6Xu1saNrR7C465zQS99nuqxaDBrR0Mr0vlof9aMDhypncQ9o+zwpMmB+8hbBMR7hv9FMKndAA+ZlVyly+GmSycnZOEfPNxQD7u4QlRwwNvMFdlFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=i2YriVaP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=stbVMQt8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=i2YriVaP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=stbVMQt8; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="i2YriVaP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="stbVMQt8"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="i2YriVaP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="stbVMQt8" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2BC266B370; Tue, 26 May 2026 09:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779786515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EoqLvghA7nnm75VwVoYR0xyMUW6WVDTVQIO7YE1VJB8=; b=i2YriVaPhthGkjlyfNtihph72bAZGeZAeI8+/eduMlVPSHURQjGaT02SEN96GAHmj4vL3p bwE788swQWxcl3HD5MNd4hT5xTp2xUBpoBrce1sSOQwaP3q6U+Y57UktZ/hfUO4H3HUugR sXXgc+Dn9ZonCYzYYCdQP2eZRFKlzTQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779786515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EoqLvghA7nnm75VwVoYR0xyMUW6WVDTVQIO7YE1VJB8=; b=stbVMQt8r9aqMs5iXhMMp0i3LAINvJCTsAVBIc8nsTZdQuGFpE9eH0SQ21GlHatc+jXBJo hCe/j7rAdpgg3LDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779786515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EoqLvghA7nnm75VwVoYR0xyMUW6WVDTVQIO7YE1VJB8=; b=i2YriVaPhthGkjlyfNtihph72bAZGeZAeI8+/eduMlVPSHURQjGaT02SEN96GAHmj4vL3p bwE788swQWxcl3HD5MNd4hT5xTp2xUBpoBrce1sSOQwaP3q6U+Y57UktZ/hfUO4H3HUugR sXXgc+Dn9ZonCYzYYCdQP2eZRFKlzTQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779786515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EoqLvghA7nnm75VwVoYR0xyMUW6WVDTVQIO7YE1VJB8=; b=stbVMQt8r9aqMs5iXhMMp0i3LAINvJCTsAVBIc8nsTZdQuGFpE9eH0SQ21GlHatc+jXBJo hCe/j7rAdpgg3LDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 399195A117; Tue, 26 May 2026 09:08:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AwGcDBJjFWr6bAAAD6G6ig (envelope-from ); Tue, 26 May 2026 09:08:34 +0000 Message-ID: <0a7fc4c9-e66d-4081-836a-69a28542e798@suse.de> Date: Tue, 26 May 2026 11:08:33 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/19] drm/plane: Add new atomic_create_state callback To: Maxime Ripard , Maarten Lankhorst , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Laurent Pinchart References: <20260519-drm-mode-config-init-v5-0-388b03321e38@kernel.org> <20260519-drm-mode-config-init-v5-10-388b03321e38@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260519-drm-mode-config-init-v5-10-388b03321e38@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TAGGED_RCPT(0.00)[renesas]; RCPT_COUNT_TWELVE(0.00)[38]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[kernel.org,linux.intel.com,gmail.com,ffwll.ch,lwn.net,linuxfoundation.org,oss.qualcomm.com,iki.fi,ideasonboard.com,intel.com,linaro.org,kwiboo.se,emersion.fr,amd.com,igalia.com,redhat.com,ursulin.net,sholland.org,raspberrypi.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLyhjdboxbrjk5hnijtjs4kbm6)]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,imap1.dmz-prg2.suse.org:helo,ideasonboard.com:email,suse.de:email,suse.de:mid] X-Spam-Level: X-Spam-Flag: NO Am 19.05.26 um 11:01 schrieb Maxime Ripard: > Commit 47b5ac7daa46 ("drm/atomic: Add new atomic_create_state callback > to drm_private_obj") introduced a new pattern for allocating drm object > states. > > Instead of relying on the reset() callback, it created a new > atomic_create_state hook. This is helpful because reset is a bit > overloaded: it's used to create the initial software state, reset it, > but also reset the hardware. > > It can also be used either at probe time, to create the initial state > and possibly reset the hardware to an expected default, but also during > suspend/resume. > > Both these cases come with different expectations too: during the > initialization, we want to initialize all states, but during > suspend/resume, drm_private_states for example are expected to be kept > around. > > reset() also isn't fallible, which makes it harder to handle > initialization errors properly. This is only really relevant for some > drivers though, since all the helpers for reset only create a new > state, and don't touch the hardware at all. > > It was thus decided to create a new hook that would allocate and > initialize a pristine state without any side effect: > atomic_create_state to untangle a bit some of it, and to separate the > initialization with the actual reset one might need during a > suspend/resume. > > Continue the transition to the new pattern with planes. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Maxime Ripard Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_atomic_state_helper.c | 25 +++++++++++++++++++++++++ > drivers/gpu/drm/drm_mode_config.c | 31 ++++++++++++++++++++++++++++++- > include/drm/drm_atomic_state_helper.h | 2 ++ > include/drm/drm_plane.h | 16 ++++++++++++++++ > 4 files changed, 73 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c > index ee01700d4ca7..ab171bfe6e86 100644 > --- a/drivers/gpu/drm/drm_atomic_state_helper.c > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c > @@ -338,10 +338,35 @@ void drm_atomic_helper_plane_reset(struct drm_plane *plane) > if (plane->state) > __drm_atomic_helper_plane_reset(plane, plane->state); > } > EXPORT_SYMBOL(drm_atomic_helper_plane_reset); > > +/** > + * drm_atomic_helper_plane_create_state - default &drm_plane_funcs.atomic_create_state hook for planes > + * @plane: plane object > + * > + * Allocates and initializes pristine @drm_plane_state. > + * > + * This is useful for drivers that don't subclass @drm_plane_state. > + * > + * RETURNS: > + * Pointer to new plane state, or ERR_PTR on failure. > + */ > +struct drm_plane_state *drm_atomic_helper_plane_create_state(struct drm_plane *plane) > +{ > + struct drm_plane_state *state; > + > + state = kzalloc_obj(*state); > + if (!state) > + return ERR_PTR(-ENOMEM); > + > + __drm_atomic_helper_plane_state_init(state, plane); > + > + return state; > +} > +EXPORT_SYMBOL(drm_atomic_helper_plane_create_state); > + > /** > * __drm_atomic_helper_plane_duplicate_state - copy atomic plane state > * @plane: plane object > * @state: atomic plane state > * > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > index c33382a38191..fa609357858f 100644 > --- a/drivers/gpu/drm/drm_mode_config.c > +++ b/drivers/gpu/drm/drm_mode_config.c > @@ -180,10 +180,36 @@ int drm_mode_getresources(struct drm_device *dev, void *data, > drm_connector_list_iter_end(&conn_iter); > > return ret; > } > > +static int drm_mode_config_plane_create_state(struct drm_plane *plane) > +{ > + struct drm_plane_state *plane_state; > + > + if (!plane->funcs->atomic_create_state) > + return 0; > + > + plane_state = plane->funcs->atomic_create_state(plane); > + if (IS_ERR(plane_state)) > + return PTR_ERR(plane_state); > + > + plane->state = plane_state; > + > + return 0; > +} > + > +static int drm_mode_config_plane_reset_with_create_state(struct drm_plane *plane) > +{ > + if (plane->state) { > + plane->funcs->atomic_destroy_state(plane, plane->state); > + plane->state = NULL; > + } > + > + return drm_mode_config_plane_create_state(plane); > +} > + > /** > * drm_mode_config_reset - call ->reset callbacks > * @dev: drm device > * > * This functions calls all the crtc's, encoder's and connector's ->reset > @@ -204,13 +230,16 @@ void drm_mode_config_reset(struct drm_device *dev) > struct drm_connector_list_iter conn_iter; > > drm_for_each_colorop(colorop, dev) > drm_colorop_reset(colorop); > > - drm_for_each_plane(plane, dev) > + drm_for_each_plane(plane, dev) { > if (plane->funcs->reset) > plane->funcs->reset(plane); > + else if (plane->funcs->atomic_create_state) > + drm_mode_config_plane_reset_with_create_state(plane); > + } > > drm_for_each_crtc(crtc, dev) > if (crtc->funcs->reset) > crtc->funcs->reset(crtc); > > diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h > index 691c1ccfa4e0..8d1ef268fdef 100644 > --- a/include/drm/drm_atomic_state_helper.h > +++ b/include/drm/drm_atomic_state_helper.h > @@ -53,10 +53,12 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state); > void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, > struct drm_crtc_state *state); > > void __drm_atomic_helper_plane_state_init(struct drm_plane_state *state, > struct drm_plane *plane); > +struct drm_plane_state * > +drm_atomic_helper_plane_create_state(struct drm_plane *plane); > void __drm_atomic_helper_plane_reset(struct drm_plane *plane, > struct drm_plane_state *state); > void drm_atomic_helper_plane_reset(struct drm_plane *plane); > void __drm_atomic_helper_plane_duplicate_state(struct drm_plane *plane, > struct drm_plane_state *state); > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > index 419c88c873a6..2c5a5a70a71b 100644 > --- a/include/drm/drm_plane.h > +++ b/include/drm/drm_plane.h > @@ -386,10 +386,26 @@ struct drm_plane_funcs { > * 0 on success or a negative error code on failure. > */ > int (*set_property)(struct drm_plane *plane, > struct drm_property *property, uint64_t val); > > + /** > + * @atomic_create_state: > + * > + * Allocate a pristine, initialized, state for the plane object > + * and return it. This callback must have no side effects: in > + * particular, the returned state must not be assigned to the > + * object's state pointer and it must not affect the hardware > + * state. > + * > + * RETURNS: > + * > + * A new, pristine, plane state instance or an error pointer > + * on failure. > + */ > + struct drm_plane_state *(*atomic_create_state)(struct drm_plane *plane); > + > /** > * @atomic_duplicate_state: > * > * Duplicate the current atomic state for this plane and return it. > * The core and helpers guarantee that any atomic state duplicated with > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)