From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327AF3F12E1 for ; Wed, 2 Sep 2026 08:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338945; cv=none; b=UI2WgGBR9shaW7srBlWhAZmcSP1xlkX5tSheNjvkDKneYUGvdrfctUTkOEGuPyYVj4nxHDUmP8g5SX50Gh5Ka7TaaNt8UJRJH9dzS32mWYVB37dAPyayG4BvKE+3gqROAebkBkpPiBde2PmWKG+3jS5CwwCHQopJCTunUroo+ZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338945; c=relaxed/simple; bh=ss5xROj8OM3lYj+pqG6TTIF5SBt62U9/oUBoQLswgBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DJcLdouSrLZX8/r0GKTwvGCSoHCSS13quafEaWTGEGhS+YtYygeP1tAnnsGnDVadkhsLlVCz0si+xYRjaE5j3BbEer5E/bJZJHb15OlsA9B+UiArhZLj936sGHyC1zhXomuvpr+VvOoyFbroKF1JJu78uvo1pztbvGvUTj0C+CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FRGhUyVe; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FRGhUyVe" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6a18e24ad25so1126267a12.1 for ; Wed, 02 Sep 2026 01:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788338942; x=1788943742; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f7aqc1YiIFFi2S/7+a4K7uWSUn18PjZkaszy4zjXDoY=; b=FRGhUyVeZHhqIQy7V+2OH9vwODwXTRs47UnHugrTgp+LSOzcThFqsRm2bSfBJMwhBk 199eI9nSLNaLiHNvQEMwpmT0gpKbAzwHhN7wqzLBlykqSHwCMXCrF6cXhYR3fiC0tX72 2J9XYkRWq68ZDFW4+MxdKrdDPS2FRzLnZuskT7IirKoyI8ysnZNo46D72xxdOyz5EDnD 0H3JcRfYn/vmWl59ZTXEHfOeLzzb4ELjTwLPeyyKnk7w8uBlCJtOSvytm6rAy+1f6Xe7 VxRrKYJrF4GcM2ZVCIp+gNMeEUCF4h7Wpu5MCZhU6mYcXgR5UdXplfMT1J+mZOP9DuVa AjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788338942; x=1788943742; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f7aqc1YiIFFi2S/7+a4K7uWSUn18PjZkaszy4zjXDoY=; b=AacziNTw2o7JNSqvQ7FVN5FvOIMscuQG6Idiu6oXXPCJP1gAfBToZMZuBU/IxN0zJR 4dvgAUgrdup94onxaH71nqfcALZStScF1cu3bg33+m7k9Up2Nv+8RrwPU+hI49+97IWt hYZYBu8kMVZOveLZwXXiF2dwbgbrOERv8DyFM0pVahGa3uo7nOggj4VzniCdUktIttoe HxxlYXNpJyIjXbph6hhaVBLo6uiBrZTnFHxt34gEo+6ASvdpaBR5fmoRzxG+OiTdcL2w iqIW98GAW+29mo3678hpwJHjMBUcazUT9mb2wA7IE8zR76oxvD1TxGN6uUxxdFm7ne7K M/Qg== X-Forwarded-Encrypted: i=1; AKwUvBy1K8DfxW5fBRc1dFVOyCGIYZrzBblCCtXjg1eo6oIFtPYp9FCdximRFnWByf/n5kBWwC99ssew0UQ=@vger.kernel.org X-Gm-Message-State: AFuF++kd/FchauAdMjyxyBLc3LAQjSRYK0+NWF4vTlZ8ugfxKPMpDGNr ur/LEdsRm6KKrtD+SeOzodKc76O6Bew+kiTYo++JaUJUtoGkpo2cujaq X-Gm-Gg: AYBFou3RIJcUhY4wqro55gTCfwLwRBl4YETNFI3m42YjLETZdoPACbcvx0VmOgKMFhQ IdFKJjrXXngLaLuaXyC2RGFONQo6epU6M1FCUzeveBGfH7rGtaq8gDAgPKEggDxjZgmALp/hUJK 4IpJeMyOE/UJ3vVf4bKlxmPsi59ASKozLKq5AN0Au17g2ggxLOSWy1s3emfJLf7rOiB0FgzcNzb DASnCKucQ++zY3RElPpHLM5uFMI+0ig1Tz4qUel2m1mCnpunMS9GnVd2YAZyr8dtANZ7P3Rpvyu tL1Rzqw7Lh1nma07Eke4sdb4EUOXoLZBINghd6ZDrxZ46x9MgLAHx3YcDwPCn0zXAL1Sjffam1F skE0Y2W4IWc9JFDhOT9oB0sLb5kPnIJ473hbx2hOa5f5PKQLHfLAMJty6d6H8Bgkq2HSYCe23/s nT1/Nb5h7xCM915qX9gYt4pEBgwdpOgikp4E69Tsk/VN/uX2/I3yOMUcRfSKBfaTX76+sAwHBxj cKix5OJ3RR0RDGbgk+63E0I9g== X-Received: by 2002:a05:6402:21d4:b0:6a3:f63a:4997 with SMTP id 4fb4d7f45d1cf-6a682567131mr2048216a12.3.1788338942157; Wed, 02 Sep 2026 01:49:02 -0700 (PDT) Received: from [172.24.138.145] ([137.71.226.102]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a67f895f29sm764636a12.2.2026.09.02.01.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 01:49:01 -0700 (PDT) Message-ID: <0c5a657d-e134-49a7-b2cd-82f293685cb7@gmail.com> Date: Wed, 2 Sep 2026 10:48:58 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support To: Jonathan Cameron , Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Mark Brown , Marius Cristea , Marcus Folkesson , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, Kent Gustavsson , linux-riscv@lists.infradead.org References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> <178813261957.2788519.4929586195765891569.b4-review@b4> Content-Language: en-US From: Janani Sunil In-Reply-To: <178813261957.2788519.4929586195765891569.b4-review@b4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/31/26 01:30, Jonathan Cameron wrote: >> >> diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile >> index 992f8930f95c..8dc644522b1e 100644 >> --- a/drivers/iio/dac/Makefile >> +++ b/drivers/iio/dac/Makefile >> @@ -18,6 +18,7 @@ obj-$(CONFIG_AD5446) += ad5446.o >> obj-$(CONFIG_AD5446_SPI) += ad5446-spi.o >> obj-$(CONFIG_AD5446_I2C) += ad5446-i2c.o >> obj-$(CONFIG_AD5449) += ad5449.o >> +obj-$(CONFIG_AD5529R) += ad5529r.o >> obj-$(CONFIG_AD5592R_BASE) += ad5592r-base.o >> obj-$(CONFIG_AD5592R) += ad5592r.o >> obj-$(CONFIG_AD5593R) += ad5593r.o >> diff --git a/drivers/iio/dac/ad5529r.c b/drivers/iio/dac/ad5529r.c >> new file mode 100644 >> index 000000000000..52601cbf28d5 >> --- /dev/null >> +++ b/drivers/iio/dac/ad5529r.c >> @@ -0,0 +1,536 @@ > Why do we need those outer () ? > > ... The outer parenthesis are required by checkpatch for macros with complex values. The same pattern is also used by AD3552R_CH_DAC() in drivers/iio/dac/ad3552r.c -Jan