From: Joe Perches <joe@perches.com>
To: "Gote, Nitin R" <nitin.r.gote@intel.com>,
Kees Cook <keescook@chromium.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"apw@canonical.com" <apw@canonical.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v5] Documentation/checkpatch: Prefer strscpy/strscpy_pad over strcpy/strlcpy/strncpy
Date: Wed, 24 Jul 2019 11:29:13 -0700 [thread overview]
Message-ID: <0d69778626901a841108ae024b8a105da679d9af.camel@perches.com> (raw)
In-Reply-To: <12356C813DFF6F479B608F81178A561587AE45@BGSMSX101.gar.corp.intel.com>
On Wed, 2019-07-24 at 18:17 +0000, Gote, Nitin R wrote:
> Hi,
Hi again.
[]
> > > > > 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad().
Please remember there does not exist a single actual use
of strscpy_pad in the kernel sources and no apparent real
need for it. I don't find one anyway.
> Could you please give your opinion on below comment.
>
> > But, if the destination buffer needs extra NUL-padding for remaining size of
> > destination, then safe replacement is strscpy_pad(). Right? If yes, then what
> > is your opinion on below change :
> >
> > "strncpy" => "strscpy, strcpy_pad - for non-NUL-terminated uses,
> > strncpy() dst should be __nonstring",
> >
> If you agree on this, then I will include this change in next patch version.
Two things:
The kernel-doc documentation uses dest not dst.
I think stracpy should be preferred over strscpy.
next prev parent reply other threads:[~2019-07-24 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 4:30 [PATCH v5] Documentation/checkpatch: Prefer strscpy/strscpy_pad over strcpy/strlcpy/strncpy NitinGote
2019-07-22 17:30 ` Kees Cook
2019-07-22 17:40 ` Joe Perches
2019-07-23 9:26 ` Gote, Nitin R
2019-07-24 18:17 ` Gote, Nitin R
2019-07-24 18:29 ` Joe Perches [this message]
2019-07-25 7:26 ` Gote, Nitin R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d69778626901a841108ae024b8a105da679d9af.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=nitin.r.gote@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox