From: Carlos Bilbao <carlos.bilbao@amd.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: corbet@lwn.net, ojeda@kernel.org, bilbao@vt.edu,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
konstantin@linuxfoundation.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] docs: Integrate rustdoc into Rust documentation
Date: Fri, 2 Dec 2022 10:30:45 -0600 [thread overview]
Message-ID: <0d6fc9fb-b875-e3fa-fe89-c40dab63fa91@amd.com> (raw)
In-Reply-To: <CANiq72kkkbhYn44Mxn=55SLNHgqoAyiEadOAkprNpQOMaNAHUg@mail.gmail.com>
On 12/2/22 10:27, Miguel Ojeda wrote:
> On Thu, Dec 1, 2022 at 9:40 PM Carlos Bilbao <carlos.bilbao@amd.com> wrote:
>> I don't understand config sync. Perhaps that, e.g. Documentation/Makefile
>> checks for broken docs, for CONFIG_WARN_MISSING_DOCUMENTS, but we don't
>> do that for rust/Makefile? I'm not sure, but it does sound orthogonal, yes.
> Config sync is what needs to happen to make a bunch of files in
> `include/` up to date with respect to the `.config`. It runs
> automatically for some targets, but not always. For instance, the
> `*docs` targets do not trigger it. So if you enable e.g.
> `CONFIG_WARN_MISSING_DOCUMENTS`, and immediately afterwards run
> `htmldocs`, it will not take it into account.
>
> But don't worry about it: that part of my comment was directed at
> others (e.g. Jon, Akira...) that may know the historical context or
> the reason behind it -- no need to fix it here. I mentioned it here
> since it affects `CONFIG_RUST` if we use it there (in the same way as
> the other `CONFIG_*` used there).
Ah, that makes sense. I appreciate the clarification!
>
> Cheers,
> Miguel
Thanks,
Carlos
next prev parent reply other threads:[~2022-12-02 16:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 22:08 [PATCH] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2022-12-01 12:42 ` Miguel Ojeda
2022-12-01 20:40 ` Carlos Bilbao
2022-12-02 16:27 ` Miguel Ojeda
2022-12-02 16:30 ` Carlos Bilbao [this message]
2022-12-01 20:48 ` [PATCH v2] " Carlos Bilbao
2022-12-05 1:06 ` Akira Yokosawa
2022-12-05 16:08 ` Miguel Ojeda
2022-12-06 13:32 ` Akira Yokosawa
2022-12-06 15:02 ` Jonathan Corbet
2022-12-06 15:39 ` Miguel Ojeda
2022-12-05 16:36 ` Carlos Bilbao
2022-12-06 14:22 ` Akira Yokosawa
2022-12-06 14:55 ` Carlos Bilbao
2022-12-06 15:01 ` Carlos Bilbao
2022-12-06 15:31 ` [PATCH v3 0/2] " Carlos Bilbao
2022-12-06 15:31 ` [PATCH v3 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2022-12-06 22:56 ` Akira Yokosawa
2022-12-07 8:27 ` Jani Nikula
2022-12-07 13:49 ` Carlos Bilbao
2022-12-07 14:15 ` Jani Nikula
2022-12-07 15:06 ` Carlos Bilbao
2022-12-07 19:33 ` Jonathan Corbet
2022-12-06 15:31 ` [PATCH v3 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2022-12-06 23:11 ` Akira Yokosawa
2022-12-07 0:06 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6fc9fb-b875-e3fa-fe89-c40dab63fa91@amd.com \
--to=carlos.bilbao@amd.com \
--cc=akiyks@gmail.com \
--cc=bilbao@vt.edu \
--cc=corbet@lwn.net \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).