From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Beata Michalska <beata.michalska@arm.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, valentin.schneider@arm.com,
corbet@lwn.net, rdunlap@infradead.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 0/3] Rework CPU capacity asymmetry detection
Date: Wed, 2 Jun 2021 21:10:05 +0200 [thread overview]
Message-ID: <0e0f8202-4acc-5092-33c1-82d268b3fd5b@arm.com> (raw)
In-Reply-To: <20210527153842.17567-1-beata.michalska@arm.com>
On 27/05/2021 17:38, Beata Michalska wrote:
[...]
> Beata Michalska (3):
> sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag
> sched/topology: Rework CPU capacity asymmetry detection
> sched/doc: Update the CPU capacity asymmetry bits
>
> Documentation/scheduler/sched-capacity.rst | 6 +-
> Documentation/scheduler/sched-energy.rst | 2 +-
> include/linux/sched/sd_flags.h | 10 ++
> kernel/sched/topology.c | 194 +++++++++++++--------
> 4 files changed, 133 insertions(+), 79 deletions(-)
Looks good to me, even though I would like to see a more compact version
of asym_cpu_capacity_classify(). Details in my response to [PATCH v6 2/3].
Did some level of testing myself and wasn't able to break it.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
prev parent reply other threads:[~2021-06-02 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:38 [PATCH v6 0/3] Rework CPU capacity asymmetry detection Beata Michalska
2021-05-27 15:38 ` [PATCH v6 1/3] sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag Beata Michalska
2021-05-27 15:38 ` [PATCH v6 2/3] sched/topology: Rework CPU capacity asymmetry detection Beata Michalska
2021-06-02 12:50 ` Valentin Schneider
2021-06-02 13:03 ` Beata Michalska
2021-06-02 19:09 ` Dietmar Eggemann
2021-06-02 19:54 ` Beata Michalska
2021-05-27 15:38 ` [PATCH v6 3/3] sched/doc: Update the CPU capacity asymmetry bits Beata Michalska
2021-06-02 19:10 ` Dietmar Eggemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e0f8202-4acc-5092-33c1-82d268b3fd5b@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=beata.michalska@arm.com \
--cc=corbet@lwn.net \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox