From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B212DCBF0; Mon, 26 May 2025 01:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748222043; cv=none; b=lGby2FaEg/MhGzKvHjaDSkHsfMtPpsoF3RRtrxY7NIgnTM4rG+V8ji+ACUX0mxAZZ6G1MvFawf1Gb4efcGmes/qP0vQ66fPf1iI3ey10t836iImxe8W1zeaMsgldqOkSg2aetzIJpNAt/Wp2+9rMSczUdrMytHrY0cxu8+603XI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748222043; c=relaxed/simple; bh=wskpfSBk00HYBA0Tej3B6ZAMAwJQx7pQ//EIJvQT524=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ZZGNGiiEBjpKZYJzP2467s263QhxKK5/HWSNKCiAkDtMHxSyjT0Bz718jbu/r9jDJesSfZSMSLr9KWcb+pmC+f0FgLXZGr2xzsONFoWbkCqjbHWZBKzFcxoUXmCFUHewNc5HJ1WAlBOcsCzT28W0Z50TgS/EoFSP0MWO31B8LZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4b5Hnw0jRPz4f3kvh; Mon, 26 May 2025 09:13:24 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id CC35E1A12F0; Mon, 26 May 2025 09:13:50 +0800 (CST) Received: from [10.174.179.143] (unknown [10.174.179.143]) by APP4 (Coremail) with SMTP id gCh0CgC3Gl9MwDNoew4aNg--.4276S3; Mon, 26 May 2025 09:13:50 +0800 (CST) Subject: Re: [PATCH 06/23] md/md-bitmap: add a new sysfs api bitmap_type To: Xiao Ni , Yu Kuai Cc: hch@lst.de, colyli@kernel.org, song@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, johnny.chenyi@huawei.com, "yukuai (C)" References: <20250524061320.370630-1-yukuai1@huaweicloud.com> <20250524061320.370630-7-yukuai1@huaweicloud.com> From: Yu Kuai Message-ID: <0e527b24-3980-2126-67f0-0958f2bc3789@huaweicloud.com> Date: Mon, 26 May 2025 09:13:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgC3Gl9MwDNoew4aNg--.4276S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw1kArWUWw4ruFykGrW8Crg_yoW3XFXEgF W8XayxJ348WF1FyF12vr1SkrWUta1xtFZ5XrZ5Zwn3X34rJa9xCrZ5Cr9Iqrn7Ja1xAwnF 9rZ8Zr17tr95ZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kI c2xKxwCYjI0SjxkI62AI1cAE67vIY487MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbGQ6JUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ Hi, 在 2025/05/26 0:32, Xiao Ni 写道: >> The api will be used by mdadm to set bitmap_ops while creating new array > Hi Kuai > > Maybe you want to say "set bitmap type" here? And can you explain more > here, why does it need this sys file while creating a new array? The > reason I ask is that it doesn't use a sys file when creating an array > with bitmap. I do mean mddev->bitmap_ops here, this is the same as mddev->pers and the md/level api. The mdadm patch will write the new helper before running array. > > And if it really needs this, can this be gotten by superblock? Theoretically, I can, however, the bitmap superblock is read by bitmap_ops->create method, and we need to set the bitmap_ops first. And changing the framwork will be much complex. Thanks, Kuai