Re: [PATCH v7 6/6] selftests/mm: add a GUP selftest

[Sarthak Sharma <sarthak.sharma@arm.com>]

Hi Mike!

On 8/24/26 1:29 PM, Mike Rapoport wrote:
>> Add a new GUP selftest which uses kselftest_harness.h. Cover
>> 12 mapping configurations: THP enabled, THP disabled and
>> HugeTLB, each across private/shared mappings and with/without
>> FOLL_WRITE. Run 7 test cases for every variant: get_user_pages,
>> get_user_pages_fast, pin_user_pages, pin_user_pages_fast,
>> pin_user_pages_longterm, and DUMP_USER_PAGES_TEST using both
>> get and pin.
>>
>> Set up 128 default-sized HugeTLB pages once for the HugeTLB variants
>> and derive their mapping size from the default huge-page size.
>>
>> Sweep four nr_pages_per_call values for each test: 1, 512, 123 and
>> all pages. This preserves the coverage previously provided by
>> run_gup_matrix(): 12 mapping combinations x 5 GUP/PUP operations x 4
>> batch sizes, for 240 ioctl calls. The two dump modes add another 96
>> calls.
>>
>> Preserve the previous sparse dump coverage with a standalone test for
>> pages 0, 19 and 0x1000. In total the selftest reports 85 TAP
>> cases and issues 337 ioctls.
>>
>> Add the new gup binary to the selftests/mm build, run_vmtests.sh and
>> MAINTAINERS.
> 
> There's also ksft_gup_test.sh ;-)

ksft_gup_test.sh runs the category "gup_test" of run_vmtests.sh via
./run_vmtests.sh -t gup_test. Both gup and gup_longterm belong to the
gup_test category. So the new test is already covered when we changed
run_vmtests.sh.

> Other than that,
> 
> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

Thank you!